Skip to content

[202_2723]: Add toolbar entries for overbrace, underbrace and underline #2862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dorodb-web22 wants to merge 1 commit into
base: main
Choose a base branch
from
+129 −1
Open

[202_2723]: Add toolbar entries for overbrace, underbrace and underline #2862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions TeXmacs/misc/pixmaps/modern/16x16/focus/tm_wide_bar.xpm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
/* XPM */
static char *magick[] = {
/* columns rows colors chars-per-pixel */
"15 17 8 1",
" c None",
"Y c #686c68",
". c #0000f8",
"X c #383cf8",
"o c #787cb8",
"O c #787cf8",
"+ c #a8aca8",
"@ c #b8bcb8",
/* pixels */
" ",
" ",
" @X ",
" XoXOO ",
" oX.X@ ",
" X...O ",
" O@X@o ",
" @O ",
" ",
" ",
" YYYYYYYY+ ",
" YYYYYYYY+ ",
" ",
" ",
" ",
" ",
" "
};
31 changes: 31 additions & 0 deletions TeXmacs/misc/pixmaps/modern/16x16/focus/tm_wide_overbrace.xpm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
/* XPM */
static char *magick[] = {
/* columns rows colors chars-per-pixel */
"15 17 8 1",
" c None",
"Y c #686c68",
". c #0000f8",
"X c #383cf8",
"o c #787cb8",
"O c #787cf8",
"+ c #a8aca8",
"@ c #b8bcb8",
/* pixels */
" ",
" ",
" +++ ",
" +YYY+ ",
" Y+ +Y ",
" YY YY ",
" Y Y ",
" ",
" ",
" @X ",
" XoXOO ",
" oX.X@ ",
" X...O ",
" O@X@o ",
" @O ",
" ",
" "
};
31 changes: 31 additions & 0 deletions TeXmacs/misc/pixmaps/modern/16x16/focus/tm_wide_underbrace.xpm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
/* XPM */
static char *magick[] = {
/* columns rows colors chars-per-pixel */
"15 17 8 1",
" c None",
"Y c #686c68",
". c #0000f8",
"X c #383cf8",
"o c #787cb8",
"O c #787cf8",
"+ c #a8aca8",
"@ c #b8bcb8",
/* pixels */
" ",
" ",
" @X ",
" XoXOO ",
" oX.X@ ",
" X...O ",
" O@X@o ",
" @O ",
" ",
" Y Y ",
" YY YY ",
" Y+ +Y ",
" +YYY+ ",
" +++ ",
" ",
" ",
" "
};
5 changes: 4 additions & 1 deletion TeXmacs/progs/math/math-menu.scm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1257,7 +1257,10 @@
((balloon (icon "tm_dot.xpm") "keyboard equivalent:") (make-wide "<dot>"))
((balloon (icon "tm_ddot.xpm") "keyboard equivalent:") (make-wide "<ddot>"))
((balloon (icon "tm_acute.xpm") "keyboard equivalent:") (make-wide "<acute>"))
((balloon (icon "tm_grave.xpm") "keyboard equivalent:") (make-wide "<grave>"))))
((balloon (icon "tm_grave.xpm") "keyboard equivalent:") (make-wide "<grave>"))
((balloon (icon "tm_wide_overbrace.xpm") "keyboard equivalent:") (make-wide "<wide-overbrace>"))
((balloon (icon "tm_wide_underbrace.xpm") "keyboard equivalent:") (make-wide-under "<wide-underbrace>"))
((balloon (icon "tm_wide_bar.xpm") "keyboard equivalent:") (make-wide-under "<wide-bar>"))))
/
(=> (balloon (icon "tm_binop.xpm") "Insert a binary operation")
(tile 8 (link binary-operation-menu)))
Expand Down
32 changes: 32 additions & 0 deletions devel/202_2723.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# [202_2723] Add toolbar entries for \overbrace, \underbrace, \underline

## Issue

#2723 — The math mode toolbar's wide accent popup is missing entries for
`\overbrace`, `\underbrace`, and `\underline`, even though they are available
in the Insert menu.

## Fix

Added 3 entries to the wide accent popup in `math-insert-icons`
(`TeXmacs/progs/math/math-menu.scm`), following the same pattern as the
existing accent buttons.

Also added 3 new XPM icons in `TeXmacs/misc/pixmaps/modern/16x16/focus/`:
- `tm_wide_overbrace.xpm`
- `tm_wide_underbrace.xpm`
- `tm_wide_bar.xpm`

## Changed Files

- `TeXmacs/progs/math/math-menu.scm`
- `TeXmacs/misc/pixmaps/modern/16x16/focus/tm_wide_overbrace.xpm`
- `TeXmacs/misc/pixmaps/modern/16x16/focus/tm_wide_underbrace.xpm`
- `TeXmacs/misc/pixmaps/modern/16x16/focus/tm_wide_bar.xpm`

## How to Test

1. Build with `xmake build stem` and run with `xmake run stem`
2. Enter math mode with `$`
3. Open the wide accent popup in the toolbar
4. Verify `\overbrace`, `\underbrace`, and `\underline` now appear and insert correctly