fix: add .js extensions to all relative imports for ESM compatibility#4
Open
noomorph wants to merge 1 commit intoMonkatraz:masterfrom
Open
fix: add .js extensions to all relative imports for ESM compatibility#4noomorph wants to merge 1 commit intoMonkatraz:masterfrom
noomorph wants to merge 1 commit intoMonkatraz:masterfrom
Conversation
- Add .js extensions to all relative imports across the codebase - Fixes ERR_MODULE_NOT_FOUND errors when importing as ES modules - Enables proper ESM resolution in Node.js environments - Affects 27 files with 124 insertions and 118 deletions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ESM import errors in Node.js (tested on Node 22.17.1 and also Bun 1.2.2) by adding
.jsextensions to all relative imports.The library was throwing ERR_MODULE_NOT_FOUND errors when imported as an ES module because Node.js couldn't resolve the module paths without explicit file extensions.
Before:
After:
Tested with
await import('./lib/index.js')- works correctly now.