Conversation
pull in changes made to main
pulling updates from main
wei-lingfeng
force-pushed
the
mm_rework
branch
2 times, most recently
from
200d7e7 to
bd7ac5e
Compare
Bootstrap memory
minor cleanup
jluastro
requested changes
Dec 3, 2025
Collaborator
jluastro
left a comment
jluastro
left a comment
There was a problem hiding this comment.
More inline comments overall would be useful. And some of the method comments aren't formatted correctly, I think. Otherwise, looks good.
Catching bootstrap_fix up with mm_rework
Bugfix for calc_bootstrap_errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motion models operational, with Acceleration and Parallax available now.