Add config for muting all games sounds when deafened.#10
Open
Phylogeny wants to merge 6 commits intoMrCrayfish:masterfrom
Open
Add config for muting all games sounds when deafened.#10Phylogeny wants to merge 6 commits intoMrCrayfish:masterfrom
Phylogeny wants to merge 6 commits intoMrCrayfish:masterfrom
Conversation
…rresponding config.
…ttom of its hitbox.
Owner
|
While going through the changes, I believe syncing the server config to client causes problems. It doesn't restore the clients config after leaving a server. A previously powerful weapon may become weak after joining and leaving a server. |
Owner
|
I can go ahead and merge this. The solution to fix is to have a copy of the config then simply use getters instead of directly accessing the config values. Inside the getter I can check if the server config is not null, return the servers value otherwise just return client value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not as nice, in my opinion; but it's worth adding as an option.
This PR also: