Skip to content

perf: filter by empty array should not run a query, [skip ci] #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MrSwitch wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

perf: filter by empty array should not run a query, [skip ci] #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions test/integration/get.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import Dare from '../../src/index.js';
// DEBUG import mysql from 'mysql2/promise';
// Import mysql from 'mysql2/promise';


const {db} = global;
const models = {
Expand Down Expand Up @@ -41,7 +42,7 @@ const schema = {
// eslint-disable-next-line arrow-body-style
dare.execute = query => {

// DEBUG console.log(mysql.format(query.sql, query.values));
// Console.log(mysql.format(query.sql, query.values));

return db.query(query);

Expand Down Expand Up @@ -183,6 +184,25 @@ const schema = {

});

it('Can ignore empty set of values', async () => {

// Create user
await dare.post('users', [{username: 'user123'}]);

// Same Structure
const resp = await dare.get({
table: 'users',
fields: ['username'],
filter: {
'username': []
},
limit: 1
});

expect(resp).to.deep.equal([]);

});

});

});