Eliminates Wix Sync race conditions #517
Merged
+184
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think this PR would be a better place to address the comments about Wix sync in this PR |
mitchelljkotler
requested changes
Dec 9, 2025
In a few cases, a task to sync an org with Wix could execute before the organization and its members are done saving to the database. This would leave the task unable to find the organization it needs to sync. By waiting until a commit, the we ensure the task has the data it needs to succeed. This also addresses a separate, low-risk race condition where the active subscription count could change between retreiving it and starting a subscription, leading us to exceed our maximum active subscription count.
allanlasser
force-pushed
the
fix-race-conditions
branch
from
f86c787 to
ead4c1b
Compare
Member
Author
|
@mitchelljkotler I filed #522 as a follow-on task. |
mitchelljkotler
requested changes
Dec 15, 2025
mitchelljkotler
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a few cases, a task to sync an org with Wix could execute before the organization and its members are done saving to the database. This would leave the task unable to find the organization it needs to sync. By waiting until a commit, the we ensure the task has the data it needs to succeed.
This also addresses a separate, low-risk race condition where the active subscription count could change between retreiving it and starting a subscription, leading us to exceed our maximum active subscription count.