-
Notifications
You must be signed in to change notification settings - Fork 11
Clarify where to find 2FA codes #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| Dismiss | ||
| </span> | ||
| </div> | ||
| <div class="_cls-alerts"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For later, we should move alerts out of base.html and into a dedicated include.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't figure out where this template is actually being used. It's not in onboarding or when I activate 2FA from my profile page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears during the 2FA sign-in step which follows username/password submission when it's enabled. The allauth.mfa library handles the logic to present it, I don't know that our code calls it directly.
eyeseast
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add this message to these two templates:
squarelet/templates/account/onboarding/mfa_setup.htmlsquarelet/templates/mfa/totp/activate_form.html
Closes #482
Some users do not know where to find their 2FA codes after enabling the feature. This adds more clarification to the screen where we ask for the code, with a link to updated documentation for even deeper clarification.
This also addresses two smaller issues:
<style>tag tomfa.cssimported byviews/mfa.tsfor Standardize how we handle static files #427