Skip to content

Conversation

@allanlasser
Copy link
Member

@allanlasser allanlasser commented Dec 8, 2025

Closes #482

Some users do not know where to find their 2FA codes after enabling the feature. This adds more clarification to the screen where we ask for the code, with a link to updated documentation for even deeper clarification.

Screenshot 2025-12-08 at 16 53 16

This also addresses two smaller issues:

  1. Relocates page styles from inline <style> tag to mfa.css imported by views/mfa.ts for Standardize how we handle static files #427
  2. Fixes positioning of alerts. I'm not sure how it broke, but it did.

@allanlasser allanlasser temporarily deployed to squarelet-pi-allanlasse-jeekhw December 8, 2025 21:57 Inactive
@allanlasser allanlasser requested a review from eyeseast December 9, 2025 18:54
Dismiss
</span>
</div>
<div class="_cls-alerts">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For later, we should move alerts out of base.html and into a dedicated include.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't figure out where this template is actually being used. It's not in onboarding or when I activate 2FA from my profile page.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears during the 2FA sign-in step which follows username/password submission when it's enabled. The allauth.mfa library handles the logic to present it, I don't know that our code calls it directly.

Copy link
Collaborator

@eyeseast eyeseast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add this message to these two templates:

  • squarelet/templates/account/onboarding/mfa_setup.html
  • squarelet/templates/mfa/totp/activate_form.html

@allanlasser allanlasser self-assigned this Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide additional instruction for how to find your 2FA code

3 participants