Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## develop #325 +/- ##
=======================================
Coverage 90.3% 90.3%
=======================================
Files 6 6
Lines 732 732
Branches 141 141
=======================================
Hits 661 661
Misses 71 71
🚀 New features to boost your workflow:
|
|
The coverage is concerning. It probably dropped because the constants header is not taken from the include directory in the device implementation anymore. However, I do not see how to fix it. In particular, the very same header should still be used by the driver directly. |
burgholzer
left a comment
There was a problem hiding this comment.
I would assume that the template itself also needs an update, but you are probably covering this in #326 (have not checked so far).
If this is supposed to go into a 1.2.2 release of QDMI, this change also needs to be back ported to the v1.2.x branch.
If this should, instead, constitute a v1.3.0 release, no back port is necessary.
(Note that we do not currently have mergifyio set up like in mqt-core, which would make this a bit easier).
burgholzer
left a comment
There was a problem hiding this comment.
Ah, the reason coverage is missing is because the QDMI library is no longer linked to the example device so the respective coverage settings are no longer propagated to the target. This needs to be fixed.
|
@burgholzer I adopted the cmake config quite a bit to enable coverage for devices. Kindly have a look, whether this is all fine. |
|
Signed-off-by: burgholzer <burgholzer@me.com>
…ly not in CI) Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
burgholzer
left a comment
There was a problem hiding this comment.
I pushed a few minor cleanups. Merging this now and creating a backport for v1.2.x.
## Description
Only two of the three headers necessary for the device interface are
prefixed. The `constants.h` is not. However, only due to this fact,
every device depends on an available QDMI installation. This PR also
adds the `constants.h` header to the files that are copied into the
include directory of the device.
## Checklist:
<!---
This checklist serves as a reminder of a couple of things that ensure
your pull request will be merged swiftly.
-->
- [x] The pull request only contains commits that are focused and
relevant to this change.
- [x] I have added appropriate tests that cover the new/changed
functionality.
- [ ] I have updated the documentation to reflect these changes.
- [x] I have added entries to the changelog for any noteworthy
additions, changes, fixes, or
removals.
- [ ] I have added migration instructions to the upgrade guide (if
needed).
- [x] The changes follow the project's style guidelines and introduce no
new warnings.
- [x] The changes are fully tested and pass the CI checks.
- [x] I have reviewed my own code changes.
---------
Signed-off-by: burgholzer <burgholzer@me.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: burgholzer <burgholzer@me.com>
Description
Only two of the three headers necessary for the device interface are prefixed. The
constants.his not. However, only due to this fact, every device depends on an available QDMI installation. This PR also adds theconstants.hheader to the files that are copied into the include directory of the device.Checklist:
removals.