Merged
Conversation
…the redundant factor of 4. Also generally a move to Nelems consistently being typed as size_t and passed through allocations as size_t allowing arrays much larger than signed int maximum.
Revamped device sided memory allocations.
…ded to batch FE submission scripts, changes to Example08 .json files, cast simTime_it to unsigned long long for curandSetPseudoRandomGeneratorSeed(), update binary converter batch script to point to pre-built conda environment on casper, and new enhanced performance Simgrid.py.
v4.0.1 bugfix patches November 2025
…output value of fricvel in surfacelayer. Added Li and Zhou paper to publications list.
Bugfix Nov2025 v4 patch-2
4 tasks
jprestop
approved these changes
Nov 18, 2025
Collaborator
jprestop
left a comment
jprestop
left a comment
There was a problem hiding this comment.
I approve this request.
jprestop
pushed a commit
that referenced
this pull request
Nov 18, 2025
* Major reconciliation of the device-sided array allocations to remove the redundant factor of 4. Also generally a move to Nelems consistently being typed as size_t and passed through allocations as size_t allowing arrays much larger than signed int maximum. * Bugfix v4.0.1 release patch items for November 2025, gpu_type=a100 added to batch FE submission scripts, changes to Example08 .json files, cast simTime_it to unsigned long long for curandSetPseudoRandomGeneratorSeed(), update binary converter batch script to point to pre-built conda environment on casper, and new enhanced performance Simgrid.py. * Remove extra factor of rho on tauxz and tauyz used in formulation os output value of fricvel in surfacelayer. Added Li and Zhou paper to publications list. --------- Co-authored-by: Domingo Muñoz-Esparza <domingom@ucar.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected Differences
If yes, please describe:
No
Pull Request Testing
Per commit individual tests performed as appropriate for the change e.g. Example01, Example02, Example08, exercising SimGrid.py coupler phase, etc.
None
Yes
N/A
If yes, describe the new output and/or changes to the existing output:
Subtle changes in specific results (i.e. fricvel output fields) are expected.
10/18/2025
Pull Request Checklist