Open
Conversation
dependencies in meta files accordingly
matusmartini
requested review from
climbfuji,
dustinswales,
grantfirl,
mdtoyNOAA and
rhaesung
as code owners
Contributor
Author
|
Is anyone still using this scheme? |
Member
|
Pinging our primary GWD developer @mdtoyNOAA |
Contributor
Author
Thank you for checking @mdtoyNOAA. Do you know if this scheme still used at NOAA? |
|
It is still used in current operational models, including GFSv16, GEFSv12 etc. All upcoming implementations will not use this scheme anymore. |
climbfuji
approved these changes
Mar 6, 2026
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Fine with me.
I will note that we should probably refrain from manual formatting changes for now until we had a discussion among the ccpp-physics developers about adopting a Fortran coding style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes:
This PR does the following:
GWD/cires_ugwpv1_oro.F90(making comparison between v0 and v1 easier).GWD/ugwp_driver_v0.FtoGWD/ugwp_driver_v0.F90and update related meta files.errflganderrmsg.Tests Conducted:
This PR does nothing, just cleanup. It gives bit-for-bit identical results in NEPTUNE.
Dependencies:
None.
Documentation:
None.