Skip to content

Update Noah-MP driver with new variables related to WRF-urban-nbs#229

Merged
cenlinhe merged 1 commit intoNCAR:release-v4.8-WRFfrom
chenghaow:v4.8-WRF-urban-nbs
Jan 15, 2026
Merged

Update Noah-MP driver with new variables related to WRF-urban-nbs#229
cenlinhe merged 1 commit intoNCAR:release-v4.8-WRFfrom
chenghaow:v4.8-WRF-urban-nbs

Conversation

@chenghaow
Copy link

This PR is related to a recent WRF PR based on v4.7.1: WRF-urban-NBS development. Updating module_sf_noahmpdrv.F with new WRF-urban-nbs related variables.

SOURCE: Yuqi Huang (University of Oklahoma), Chenghao Wang (University of Oklahoma)

Update driver with new WRF-urban-nbs related variables
@cenlinhe cenlinhe requested review from cenlinhe and tslin2 January 14, 2026 22:17
Copy link
Collaborator

@cenlinhe cenlinhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. This PR is to make the old non-refactored noahmp driver module that calls urban subroutine work with the new urban tree schemes added to WRF which includes 8 newly added urban variables. Nothing is changed from the NoahMP side. All changes are related to urban.

@cenlinhe
Copy link
Collaborator

@tslin2 could you please take a quick look at this? This also needs a quick approval so that the WRF PR is able to be updated. Also, once our refactored coupling with WRF is approved, I will update these urban interface subroutine call in our refactored NoahMP code as well. For now, to make the non-refactored WRF PR pass regression test, we have to do this non-refactored code updates first, because the refactored coupling is delayed.

@cenlinhe
Copy link
Collaborator

@chenghaow Did you test the compilation with these Noah-MP code changes for your coupled WRF code? Is it successful?

Copy link
Collaborator

@tslin2 tslin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@cenlinhe cenlinhe merged commit 1d4d953 into NCAR:release-v4.8-WRF Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants