Skip to content

bug fix for canopy interception and canopy evaporation#238

Open
tslin2 wants to merge 4 commits intoNCAR:developfrom
tslin2:develop
Open

bug fix for canopy interception and canopy evaporation#238
tslin2 wants to merge 4 commits intoNCAR:developfrom
tslin2:develop

Conversation

@tslin2
Copy link
Collaborator

@tslin2 tslin2 commented Mar 3, 2026

A fix for issue of vegetation temperature with wet canopy (addressing abnormal vegetation temperature behavior when canopy interception exists) based on NOAA:
https://github.com/ufs-community/ccpp-physics/blob/9e709790d12301e697634e55af25224708b54a80/physics/SFC_Models/Land/Noahmp/module_sf_noahmplsm.F90#L4240-L4250

The test has been performed in WRF over CONUS at 4km

@cenlinhe
Copy link
Collaborator

cenlinhe commented Mar 3, 2026

did you test if the HRLDAS with this latest NoahMP refactored code runs fine? Could you please upload a few plots showing the comparison from your WRF tests with and without this bug fix?

@tslin2
Copy link
Collaborator Author

tslin2 commented Mar 3, 2026

did you test if the HRLDAS with this latest NoahMP refactored code runs fine? Could you please upload a few plots showing the comparison from your WRF tests with and without this bug fix?

No, the below figures were from Dr. Changhai Liu

CBIOM=0.02 ,Tmin
image

CBIOM=0.02 with CEW limit ,Tmin
image

CBIOM=0.02 ,Tmax
image

CBIOM=0.02 with CEW limit ,Tmax
image

@cenlinhe
Copy link
Collaborator

cenlinhe commented Mar 3, 2026

OK, we need to at least test if HRLDAS/NoahMP with your code changes runs successfully (no crash) and see how much difference it makes in T2MV, TV, and ECAN. When you have time, could you please do a quick test using NLDAS-2 forcing or any other available forcing data you already have?

@tslin2
Copy link
Collaborator Author

tslin2 commented Mar 3, 2026

OK, we need to at least test if HRLDAS/NoahMP with your code changes runs successfully (no crash) and see how much difference it makes in T2MV, TV, and ECAN. When you have time, could you please do a quick test using NLDAS-2 forcing or any other available forcing data you already have?

I would suggest doing this before the next release of the version for all changes at one time through some testbed setups. NOAA performed the test showing that the modeling skills of 2-meter air temperature and dewpoint temperature have been improved. There are other changes in the NOAA version.

@cenlinhe
Copy link
Collaborator

cenlinhe commented Mar 3, 2026

Sure, sounds good to me.

@tslin2
Copy link
Collaborator Author

tslin2 commented Mar 4, 2026

The machine maintenance is back, the HRLDAS compiles and runs successfully (no crash). We should select a few test cases and visual workflows for future testing and evaluation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants