bug fix for canopy interception and canopy evaporation#238
bug fix for canopy interception and canopy evaporation#238tslin2 wants to merge 4 commits intoNCAR:developfrom
Conversation
|
did you test if the HRLDAS with this latest NoahMP refactored code runs fine? Could you please upload a few plots showing the comparison from your WRF tests with and without this bug fix? |
|
OK, we need to at least test if HRLDAS/NoahMP with your code changes runs successfully (no crash) and see how much difference it makes in T2MV, TV, and ECAN. When you have time, could you please do a quick test using NLDAS-2 forcing or any other available forcing data you already have? |
I would suggest doing this before the next release of the version for all changes at one time through some testbed setups. NOAA performed the test showing that the modeling skills of 2-meter air temperature and dewpoint temperature have been improved. There are other changes in the NOAA version. |
|
Sure, sounds good to me. |
|
The machine maintenance is back, the HRLDAS compiles and runs successfully (no crash). We should select a few test cases and visual workflows for future testing and evaluation. |




A fix for issue of vegetation temperature with wet canopy (addressing abnormal vegetation temperature behavior when canopy interception exists) based on NOAA:
https://github.com/ufs-community/ccpp-physics/blob/9e709790d12301e697634e55af25224708b54a80/physics/SFC_Models/Land/Noahmp/module_sf_noahmplsm.F90#L4240-L4250
The test has been performed in WRF over CONUS at 4km