Fix bug for thinning option in the goes_abi converter and update README files#5
Open
Fix bug for thinning option in the goes_abi converter and update README files#5
Conversation
…bsample pixels. If super_ob is true, then no thinning is done. The readme files for abi namelist and ahi converter usage are updated to include more accurate information for users.
Collaborator
Author
|
@gthompsnJCSDA Could you please provide a review for this bug fix? For some reason I can't add you in the Reviewers section. |
|
@ibanos90, did you compile and run this version? Please say so in the PR comment and mention how the output is verified, like visual inspection using ncdump or some other method. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue that was found when neither the
do_thinningordo_superoboptions were set astruein the namelist for thegoes-abi_converter. Here, thedo_thinningoption is removed, allowingdo_superobto control whether superobbing or thinning is performed. The default option is no superobbing and the number of pixels to skip is controlled by the user definedn_subsampleparameter via namelist. Ifn_subsampleis equal to 1, then no thinning is done and all pixels are kept. TheREADME.mdfiles for the ABI namelist and AHI converter usage are also updated to include more accurate information for users. A small bug was also fixed in the code for thinning AHI observations.Thank you @gthompsnJCSDA for pointing out this issue in the code.