Fix notification sounds

ContentScript.js

@@ -121,9 +121,24 @@ function onPlay(e) {
   let data = Elements.get(e);
   if (isMuted(e)) {
     send('playMuted');
-  } else {
-    send('play', data.id);
+    return;
   }
+  // If duration is unknown, wait for metadata before reporting to background.
+  // This lets the background correctly identify short media (e.g. notification sounds).
+  if (isNaN(e.duration)) {
+    let sent = false;
+    const sendOnce = () => {
+      if (sent) return;
+      sent = true;
+      if (!isPaused(e) && !isMuted(e)) {
+        send('play', data.id, e.duration);
+      }
+    };
+    e.addEventListener('durationchange', sendOnce, {once: true});
+    setTimeout(sendOnce, 500);
+    return;
+  }
+  send('play', data.id, e.duration);
 }
 
 function validMedia(e) {
@@ -336,12 +351,14 @@ function checkDOM() {
   }
 }
 
-function send(message, body = '') {
-  chrome.runtime.sendMessage({
+function send(message, body = '', duration) {
+  const msg = {
     type: message,
     body: body,
     userActivation: navigator.userActivation.isActive
-  });
+  };
+  if (duration !== undefined) msg.duration = duration;
+  chrome.runtime.sendMessage(msg);
 }
 
 window.addEventListener(

background.js

@@ -3,6 +3,9 @@
 var state = {};
 
 const resumelimit = 5;
+const shortMediaDuration = 3; // seconds
+const shortMediaDebounce = 5000; // ms, for tabs without content script access
+const pendingAudible = new Map();
 const setItems = [
   'media',
   'backgroundaudio',
@@ -127,6 +130,14 @@ chrome.runtime.onMessage.addListener(async (message, sender) => {
         state.mutedMedia.add(sender.tab.id);
         onMute(sender.tab.id);
       } else {
+        // Ignore short media (e.g. notification sounds) when option is enabled.
+        if (
+          hasProperty(options, 'ignoreshort') &&
+          isFinite(message.duration) &&
+          message.duration > 0 &&
+          message.duration < shortMediaDuration
+        )
+          break;
         state.mutedMedia.delete(sender.tab.id);
         state.media.add(sender.tab.id);
         onPlay(sender.tab, message.body, message.userActivation);
@@ -449,6 +460,10 @@ function remove(tabId) {
   state.backgroundaudio.delete(tabId);
   state.mutedTabs.delete(tabId);
   state.legacyMedia.delete(tabId);
+  if (pendingAudible.has(tabId)) {
+    clearTimeout(pendingAudible.get(tabId));
+    pendingAudible.delete(tabId);
+  }
   onPause(tabId);
 }
 
@@ -487,8 +502,28 @@ chrome.tabs.onUpdated.addListener(async (tabId, changeInfo, tab) => {
       if (hasProperty(options, 'ask'))
         chrome.permissions.addHostAccessRequest({tabId: tabId});
     }
-    onPlay(tab);
+    // Debounce otherTabs when ignoreshort is enabled to filter notification sounds.
+    if (
+      hasProperty(options, 'ignoreshort') &&
+      state.otherTabs.has(tabId)
+    ) {
+      if (pendingAudible.has(tabId)) clearTimeout(pendingAudible.get(tabId));
+      pendingAudible.set(
+        tabId,
+        setTimeout(() => {
+          pendingAudible.delete(tabId);
+          if (state.otherTabs.has(tabId)) onPlay(tab);
+        }, shortMediaDebounce)
+      );
+    } else {
+      onPlay(tab);
+    }
   } else {
+    // Cancel pending debounce if tab stopped being audible.
+    if (pendingAudible.has(tabId)) {
+      clearTimeout(pendingAudible.get(tabId));
+      pendingAudible.delete(tabId);
+    }
     state.otherTabs.delete(tabId);
     onPause(tabId);
   }

options.html

@@ -31,6 +31,11 @@ <h1>After changes press enter.</h1>
       <label for="ignoreother"> Ignore media from other tabs</label
       ><input type="checkbox" id="ignoreother" />
     </div>
+    <div>
+      <label for="ignoreshort">
+        Ignore short media under 3 seconds (e.g. notification sounds)</label
+      ><input type="checkbox" id="ignoreshort" />
+    </div>
     <div>
       <label for="nopermission">
         No permission mode, discards tabs when needed.</label

options.js

@@ -11,6 +11,7 @@ const supported = [
   'ignoretabchange',
   'muteonpause',
   'ignoreother',
+  'ignoreshort',
   'nopermission',
   'permediapause',
   'checkidle',