partitioning subset hydrofabrics (NGWPC-6553)#44
Closed
cmaynard-ngwpc wants to merge 9 commits intorelease-candidatefrom
Closed
partitioning subset hydrofabrics (NGWPC-6553)#44cmaynard-ngwpc wants to merge 9 commits intorelease-candidatefrom
cmaynard-ngwpc wants to merge 9 commits intorelease-candidatefrom
Conversation
…es in the standard
Author
|
We are merging the current release-candidate branch to development and these commits are already part of development. Moved to draft until this process is done, then will close. |
Author
|
Closing because we have suspended updating |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR, partitioning a hydrofabric in which there was a nexus that had multiple contributing catchments and no downstream catchment could lead to corrupted run results if those catchments were spread across multiple processes.
Fixes: NOAA-OWP#284
Additions
SentinelFeaturetype for the placeholder GeoJSON features that have no geography or geometry associated with themChanges
partitionGeneratorinput, and add sentinel flowpaths downstream of themRemovals
Testing
partitionGeneratoron test subset hydrofabric from bug report looks as intendedScreenshots
Checklist