Skip to content

Comments

EWTS Logging Does Not Use Global Default#48

Open
idtodd wants to merge 2 commits intodevelopmentfrom
idt-unique-ewts-logging
Open

EWTS Logging Does Not Use Global Default#48
idtodd wants to merge 2 commits intodevelopmentfrom
idt-unique-ewts-logging

Conversation

@idtodd
Copy link

@idtodd idtodd commented Nov 13, 2025

Logging was previously done with logging.getLogger("") to synchronize between files. This method could cause different ngen modules running on the same python interpreter to overwrite which module is responsible for the message. This update changes the logger to use "T-route" as its logger name to prevent this potential conflict.

Changes

  • Use the module's name ("T-route") for all instances of logging.

Testing

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant