Skip to content

Comments

Add first draft CONUS test cases#80

Open
sclaw wants to merge 2 commits intonhf-routingfrom
pi-9-NGWPC-9839
Open

Add first draft CONUS test cases#80
sclaw wants to merge 2 commits intonhf-routingfrom
pi-9-NGWPC-9839

Conversation

@sclaw
Copy link

@sclaw sclaw commented Feb 24, 2026

This PR adds a new test to the nhf test suite with a CONUS-wide dataset. This test runs t-route for a portion of the 2022 US summer floods over all of CONUS. Channel forcing data is retrieved from National Water Model 3.0 retrospective data. This test is more a test of the nhf data than of t-route code. For that reason, these tests should not be run in the default pytest test set. The test_nhf_conus function has therefore been marked as an integration test.

Additions

  • test/nhf/conus/make_forcing.py
  • test/nhf/conus/README.md
  • test/nhf/test_conus.py

Removals

  • None

Changes

  • None

Testing

  1. Issues with nhf 0.4.1 prevented t-route from running on the test dataset.

Screenshots

Notes

  • Due to the large size of both the CONUS nhf and the channel forcing data for t-route, no data has been included in this PR. Users should copy nhf to their local machine and follow the instructions in test/nhf/conus/README.md to create the dataset and setup the test directory.
  • One of the existing tests was failing, and no attempt has been made to resolve it. test_hyfeatures_network.py fails because lake_id field is not available. Tadd noted this here: patch: fixed broken lower colorado test #31. This test should be removed. Line 138 (nexus) also broken for that test. yuqiong e3a4998

Todos

  • Issues with nhf 0.4.1 prevented t-route from running on the test dataset. Once the issues are resolved, the simulation time-window may be adjusted to better match event start and end times.
  • More tests are needed to determine if the t-route run for this is successful, once the nhf 0.4.1 issue is resolved.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • [] Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@sclaw sclaw changed the title Pi 9 ngwpc 9839 Add first draft CONUS test cases Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant