Skip to content

Comments

Updates for integration with dWGS DRS implementation#24

Draft
gelparsons wants to merge 7 commits intomainfrom
updates-for-new-drs-implementation
Draft

Updates for integration with dWGS DRS implementation#24
gelparsons wants to merge 7 commits intomainfrom
updates-for-new-drs-implementation

Conversation

@gelparsons
Copy link
Collaborator

@gelparsons gelparsons commented Dec 29, 2025

  • Adds option to configure FHIR and DRS URLs directly, primarily for internal testing and for when DRS and FHIR do not share the same base URL.
  • Converting to/from DRS/HTTPS URLs has been made more flexible to allow for no "api-name" in the base path, in the case where the DRS server is configured directly.
  • The dWGS DRS implementation at GEL returns snake_case credentials to S3 buckets. To allow for some flexibility, the client has been changed to be agnostic to how S3 credentials are cased by the DRS server, rather than assume keys are cased exactly as S3 requires.
  • DRS uploads now use the newer register-objects endpoint, rather than posting objects directly.
  • DRS paths now use "v1" instead of "v1.4".

The DRS api has changed since the PoC. Now we register-objects by providing candidates, rather than POSTing directly using fully-formed DRS objects.

This changes the flow because we need the DRS server response to obtain a full DRS object.
Note, the version is kept below 1.0 so as not to signal stability.
@gelparsons gelparsons requested a review from cboustred December 29, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant