Switch to nhsuk-prototype-kit package

[frankieroberto]

A spike to see if/how the nhsuk-prototype-rig could be swapped out for the (not yet released) nhsuk-prototype-kit package.

Part of nhsuk/nhsuk-prototype-kit-package#49

[paulrobertlloyd]

@frankieroberto Oooh, I was thinking of trying this, glad you’ve taken up the challenge! How does it fair?

[frankieroberto]

@paulrobertlloyd well it’s not working yet. Need to take some time to go through all the errors one by one.

I’d like to switch the package from CommonJS to ESM modules but probably it needs to work with both for a while?!

One other issue is that your prototype uses .njk instead of .html so the auto routes don’t work. Probably it should work with both options!

[paulrobertlloyd]

@frankieroberto Give up!?

[frankieroberto]

@paulrobertlloyd no just ran out of time that night! Will pick this up again soon. Might end up being a Christmas break project.

Feel free to push any commits if you spot anything.

[frankieroberto]

@paulrobertlloyd ok, 1 step closer to working. I’ve updated the kit (8.0.0-internal.5) to support ES modules. The prototype will now start, and the CSS files are built.

However all the pages throw an error - which I think is because the prototype is now missing all Postgres database stuff. Looks like the connect-pg-simple package would need to be added to the prototype along with this code? https://github.com/x-govuk/nhsuk-prototype-rig/blob/main/lib/server.js#L124-L143

One for another day!

[colinrotherham]

@paulrobertlloyd Need you to add a PASSWORD env to the review app 🙏

We should ideally add a globals option (alongside filters) and I've had to temporarily turn off the PostgreSQL session middleware for now, but the v8 prototype kit version is up and running 😎

[frankieroberto]

@colinrotherham there was already a PASSWORD env set up, but the kit requires a PROTOTYPE_PASSWORD one (not sure why but it always has). I've added it now (password: mavis). Seems to work!

@paulrobertlloyd give it a test?

[paulrobertlloyd]

This is mostly working now, but one outstanding issue is request.body often returning an empty object ({}) when a form is submitted, which isn’t the case currently.

I thought adding the following would work:

app.use(express.json())
app.use(
  express.urlencoded({
    extended: true
  })
)

As this is used in the Rig. However this made no difference. This’ll need some more digging to resolve.

[frankieroberto]

@paulrobertlloyd can you remember which pages/routes the request.body is being set to an empty object on?

[colinrotherham]

Does this break all the internal error views etc that use .html extensions?

Or basic things like password.html in Heroku?

I've proposed a fix in nhsuk/nhsuk-prototype-kit-package#260

But otherwise, could you add the extensions manually for now?

- response.render('dashboard')
+ response.render('dashboard.njk')

[colinrotherham]

We use this port for Browsersync now, not Express

So assuming you want to continue using http://localhost:3000

Suggested change

	prototype.start(2000)
	prototype.start(3000)

[colinrotherham]

This app will receive a second app.use(session) store 😔

I'm not quite sure how that might behave, unless it's somehow adding a different non-conflicting name to the request?

Similarly expect lots of async session weirdness:

• We reset using req.session.data = {} not req.session.regenerate()
• We don't wait for req.session.save() before redirecting after POST

Probably need to wait for (and help test) this new feature instead:

• Add new Express session option nhsuk/nhsuk-prototype-kit-package#220

[paulrobertlloyd]

@paulrobertlloyd can you remember which pages/routes the request.body is being set to an empty object on?

Try logging in as a nurse, going to an in progress session, and registering a child. And if that works, recording a vaccination. That whole flow is broken right now.