Skip to content

APPT-2069 Fixed scope of CancelDateRangeWithBooking flag#1492

Open
Dave-O-NHS wants to merge 1 commit intomainfrom
APPT-2069-fix-scope-of-cancel-date-range-with-bookings-flag
Open

APPT-2069 Fixed scope of CancelDateRangeWithBooking flag#1492
Dave-O-NHS wants to merge 1 commit intomainfrom
APPT-2069-fix-scope-of-cancel-date-range-with-bookings-flag

Conversation

@Dave-O-NHS
Copy link
Contributor

Description

On the cancellation impact page, CancelADateRangeWithBookings flag was incorrectly blocking no sessions and no bookings pages.
This issue has been fixed, and CancelADateRangeWithBookings flag only restricts page for cancellation that contains sessions and bookings, in which case, we display "You cannot cancel these sessions" page.

Checklist:

  • My work is behind a feature toggle (if appropriate)
  • If my work is behind a feature toggle, I've added a full suite of tests for both the ON and OFF state
  • The ticket number is in the Pull Request title, with format "APPT-XXX: My Title Here"
  • I have ran npm tsc / lint (in the future these will be ran automatically)
  • My code generates no new .NET warnings (in the future these will be treated as errors)
  • If I've added a new Function, it is disabled in all but one of the terraform groups (e.g. http_functions)
  • If I've added a new Function, it has both unit and integration tests. Any request body validators have unit tests also
  • If I've made UI changes, I've added appropriate Playwright and Jest tests
  • If I've added/updated an end-point, I've added the appropriate annotations and tested the Swagger documentation reflects the change

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant