Skip to content

Conversation

@JParkesAD
Copy link
Contributor

@JParkesAD JParkesAD commented Oct 21, 2025

CLOSES AB#25794

Copilot AI review requested due to automatic review settings October 21, 2025 16:08
@github-actions github-actions bot added the CODE RUB The code rub category is for small changes (not for bug fixes) label Oct 21, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors OData pagination configuration by removing DEBUG-based conditional compilation directives and centralizing page size settings. The changes move from inline PageSize attributes in controllers to a configuration-based approach using appsettings.json and EDM model configuration.

  • Removes #if DEBUG conditional compilation blocks from all controller methods
  • Centralizes page size configuration in appsettings.json for both Portal and Manage servers
  • Implements page size configuration at the EDM model level in GetEdmModel() methods

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
LondonDataServices.IDecide.Portal.Server/appsettings.json Adds OData PageSize configuration (50)
LondonDataServices.IDecide.Portal.Server/Program.cs Reads page size from config and applies it to entity sets in EDM model; removes unused imports
LondonDataServices.IDecide.Portal.Server/Controllers/PatientsController.cs Removes DEBUG conditional PageSize attributes from Get endpoint
LondonDataServices.IDecide.Portal.Server/Controllers/DecisionsController.cs Removes DEBUG conditional PageSize attributes from Get endpoint
LondonDataServices.IDecide.Portal.Server/Controllers/DecisionTypesController.cs Removes DEBUG conditional PageSize attributes from Get endpoint
LondonDataServices.IDecide.Manage.Server/appsettings.json Adds OData PageSize configuration (50)
LondonDataServices.IDecide.Manage.Server/Program.cs Reads page size from config and applies it to entity sets in EDM model; adds required imports
LondonDataServices.IDecide.Manage.Server/Controllers/PatientsController.cs Removes DEBUG conditional PageSize attributes from Get endpoint
LondonDataServices.IDecide.Manage.Server/Controllers/DecisionsController.cs Removes DEBUG conditional PageSize attributes from Get endpoint
LondonDataServices.IDecide.Manage.Server/Controllers/DecisionTypesController.cs Removes DEBUG conditional PageSize attributes from Get endpoint
LondonDataServices.IDecide.Manage.Server/Controllers/Consumers/ConsumersController.cs Removes DEBUG conditional PageSize attributes from Get endpoint
LondonDataServices.IDecide.Manage.Server/Controllers/ConsumerAdoptions/ConsumerAdoptionsController.cs Removes DEBUG conditional PageSize attributes from Get endpoint

@JParkesAD JParkesAD marked this pull request as draft October 22, 2025 09:37
Copilot AI review requested due to automatic review settings October 22, 2025 10:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.

@JParkesAD JParkesAD marked this pull request as ready for review October 22, 2025 10:10
Copilot AI review requested due to automatic review settings October 28, 2025 13:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CODE RUB The code rub category is for small changes (not for bug fixes) resolve conflicts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants