-
Notifications
You must be signed in to change notification settings - Fork 0
CODE RUB: Controllers remove page size debug comments #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CODE RUB: Controllers remove page size debug comments #175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors OData pagination configuration by removing DEBUG-based conditional compilation directives and centralizing page size settings. The changes move from inline PageSize attributes in controllers to a configuration-based approach using appsettings.json and EDM model configuration.
- Removes
#if DEBUGconditional compilation blocks from all controller methods - Centralizes page size configuration in
appsettings.jsonfor both Portal and Manage servers - Implements page size configuration at the EDM model level in
GetEdmModel()methods
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| LondonDataServices.IDecide.Portal.Server/appsettings.json | Adds OData PageSize configuration (50) |
| LondonDataServices.IDecide.Portal.Server/Program.cs | Reads page size from config and applies it to entity sets in EDM model; removes unused imports |
| LondonDataServices.IDecide.Portal.Server/Controllers/PatientsController.cs | Removes DEBUG conditional PageSize attributes from Get endpoint |
| LondonDataServices.IDecide.Portal.Server/Controllers/DecisionsController.cs | Removes DEBUG conditional PageSize attributes from Get endpoint |
| LondonDataServices.IDecide.Portal.Server/Controllers/DecisionTypesController.cs | Removes DEBUG conditional PageSize attributes from Get endpoint |
| LondonDataServices.IDecide.Manage.Server/appsettings.json | Adds OData PageSize configuration (50) |
| LondonDataServices.IDecide.Manage.Server/Program.cs | Reads page size from config and applies it to entity sets in EDM model; adds required imports |
| LondonDataServices.IDecide.Manage.Server/Controllers/PatientsController.cs | Removes DEBUG conditional PageSize attributes from Get endpoint |
| LondonDataServices.IDecide.Manage.Server/Controllers/DecisionsController.cs | Removes DEBUG conditional PageSize attributes from Get endpoint |
| LondonDataServices.IDecide.Manage.Server/Controllers/DecisionTypesController.cs | Removes DEBUG conditional PageSize attributes from Get endpoint |
| LondonDataServices.IDecide.Manage.Server/Controllers/Consumers/ConsumersController.cs | Removes DEBUG conditional PageSize attributes from Get endpoint |
| LondonDataServices.IDecide.Manage.Server/Controllers/ConsumerAdoptions/ConsumerAdoptionsController.cs | Removes DEBUG conditional PageSize attributes from Get endpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.
LondonDataServices.IDecide.Portal.Server/ConfigurableEnableQueryAttribute.cs
Show resolved
Hide resolved
LondonDataServices.IDecide.Portal.Server/ConfigurableEnableQueryAttribute.cs
Show resolved
Hide resolved
LondonDataServices.IDecide.Portal.Server/ConfigurableEnableQueryAttribute.cs
Show resolved
Hide resolved
LondonDataServices.IDecide.Manage.Server/ConfigurableEnableQueryAttribute.cs
Show resolved
Hide resolved
LondonDataServices.IDecide.Manage.Server/ConfigurableEnableQueryAttribute.cs
Show resolved
Hide resolved
LondonDataServices.IDecide.Manage.Server/ConfigurableEnableQueryAttribute.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
CLOSES AB#25794