Report back what changes were made to logging and require at least one option set#503
Merged
mozzieongit merged 4 commits intomainfrom Mar 9, 2026
Merged
Report back what changes were made to logging and require at least one option set#503mozzieongit merged 4 commits intomainfrom
mozzieongit merged 4 commits intomainfrom
Conversation
ximon18
reviewed
Mar 9, 2026
mozzieongit
commented
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
--trace-targetsI got confused that
cascade debug change-loggingstated that it changed the logging, but I didn't give it any options, so I wondered what it changed to. Turns out it didn't actually change anything.This PR changes the behaviour to require at least one of the options to be provided, and log what the changes submitted to the server are.
Arguably, now that at least one of the options is required, the verbosity is not really required anymore.
I opted to only set
leveltorequired_unless_present_any ..., as not to confuse users with clap's error message stating that both would be required:Instead, it only shows
--levelas required, as that is the option most commonly used I assume.Additionally, the help text states that "at least on option of 'level' or 'trace-targets' is required".