Open
Conversation
tertsdiepraam
force-pushed
the
less-get-zone
branch
from
72bfd98 to
acfbd07
Compare
tertsdiepraam
force-pushed
the
less-get-zone
branch
from
af7b25f to
877916f
Compare
tertsdiepraam
force-pushed
the
less-get-zone
branch
from
877916f to
7a3307f
Compare
ximon18
reviewed
Mar 11, 2026
ximon18
reviewed
Mar 11, 2026
ximon18
reviewed
Mar 11, 2026
ximon18
reviewed
Mar 11, 2026
ximon18
reviewed
Mar 11, 2026
ximon18
reviewed
Mar 11, 2026
tertsdiepraam
force-pushed
the
less-get-zone
branch
from
45ca418 to
6fc5b91
Compare
bal-e
approved these changes
Mar 13, 2026
src/units/zone_signer.rs
Outdated
Comment on lines
+1000
to
+1002
| let state = ¢er.state.lock().unwrap(); | ||
| let now = SystemTime::now(); | ||
| for zone in zone_tree.load().iter_zones() { | ||
| let zone_name = zone.apex_name(); | ||
| for zone in &state.zones { |
Contributor
There was a problem hiding this comment.
Maybe clone out state.zones so you don't hold the lock for very long?
Contributor
Author
There was a problem hiding this comment.
Sure. Also I see you added a get_zone below that I can remove as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should reduce the possibility for deadlocks a bit and reduces the contention on the
center.statemutex.Some calls are just move from the callee to the caller, because then they happen more at the "edge". For example, the http server now does more of these calls because it needs to translate the names from the API to actual zones and it makes sense to do that there.
Builds on #504 but doesn't merge into it because I think that shouldn't be merged directly.