Conversation
12 tasks
mozzieongit
reviewed
Nov 14, 2024
This reverts commit 643ab86. See: <#9 (comment)>
Contributor
tertsdiepraam
left a comment
tertsdiepraam
left a comment
There was a problem hiding this comment.
Well done! It's not super pretty, but it's about what you can expect for so much IO. I'd love to see this tested before we merge this.
mozzieongit
reviewed
Nov 28, 2024
| // TODO: Attempt repeated generation to avoid key tag collisions. | ||
| let (secret_key, public_key) = common::generate(params) | ||
| .map_err(|err| format!("an implementation error occurred: {err}").into()) | ||
| .context("generating a cryptographic keypair")?; |
tertsdiepraam
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP.