Make varbc file names more generic by CoryMartin-NOAA · Pull Request #2071 · NOAA-EMC/GDASApp

CoryMartin-NOAA · 2026-02-19T18:27:10Z

Description

This PR changes the suffixes of the VarBC files from satbias.nc to bias.nc and satbias_cov to bias_cov.
Additionally the tar ball is renamed from rad_varbc_params to varbc_params to include any aircraft VarBC files.

Companion PRs

Will require a sync'd global-workflow PR to work properly. Coming soon.

Issues

None

Automated CI tests to run in Global Workflow

RussTreadon-NOAA · 2026-03-04T15:56:15Z

WCOSS2 tests

Install feature/varbc at 3849e19 inside g-w forked branch CoryMartin-NOAA:feature/varbc at 1bd20f4 on Dogwood. Run GDASApp ctests. Initial tests encountered failures in atm_jjob, C48_ufsenkf_atmDA, and C96C48_ufsgsi_hybatmDA.

The following changes were made to the local copy of feature/varbc

test/atm/global-workflow/jjob_ens_init.sh - update name of JEDI bias correction tarball
test/atm/global-workflow/jjob_var_init.sh - update name of JEDI bias correction tarball
ush/gsi_satbias2ioda_all.sh - update name of JEDI bias correction tarball, update names of bias correction files

Two additional files were modified in the working copy of CoryMartin-NOAA:feature/varbc. See g-w PR #4571 for details.

With these changes all GDASApp ctest, including select g-w CI, Passed on Dogwood.

Test project /lfs/h2/emc/da/noscrub/russ.treadon/git/global-workflow/pr4571/sorc/gdas.cd/build
        Start 221: test_gdasapp_C96C48_ufsgsi_hybatmDA
        Start 243: test_gdasapp_C48_ufsenkf_atmDA
        Start 179: test_gdasapp_C96C48_hybatmDA
        Start 198: test_gdasapp_C96C48_ufs_hybatmDA
        Start 273: test_gdasapp_C96C48_hybatmsnowDA
        Start 257: test_gdasapp_C96_gcafs_cycled
        Start 305: test_gdasapp_C48mx500_hybAOWCDA
        Start 294: test_gdasapp_C48mx500_3DVarAOWCDA
        Start 320: test_gdasapp_setup_atm_jjob_cycled_exp
        Start 319: test_gdasapp_convert_gsi_satbias
        Start 175: test_gdasapp_check_python_norms
        Start 178: test_gdasapp_snow_create_ens
  1/158 Test #178: test_gdasapp_snow_create_ens .............................................   Passed    3.92 sec
        Start 177: test_gdasapp_jcb_installation
  2/158 Test #175: test_gdasapp_check_python_norms ..........................................   Passed    4.44 sec
...
157/158 Test #330: test_gdasapp_atm_jjob_ens_inc ............................................   Passed  141.99 sec
        Start 331: test_gdasapp_atm_jjob_ens_final
158/158 Test #331: test_gdasapp_atm_jjob_ens_final ..........................................   Passed   38.98 sec

100% tests passed, 0 tests failed out of 158

Label Time Summary:
gdasapp    = 29201.79 sec*proc (152 tests)
script     = 29201.79 sec*proc (152 tests)

Total Test time (real) = 2745.46 sec

RussTreadon-NOAA · 2026-03-04T20:34:36Z

GDASApp CI failures and fix

GDASApp atm_jjob fails after merging g-w develop into g-w PR #4571.

g-w recently removed the use of declare_from_tmpl. The atm_jjob init scripts in GDASApp feature/stable-nightly have been updated to work without declare_from_tmpl. Add this update to feature/varbc at 62f2833. This commit included a typo in the name of the varbc tarball. Correct this at e4aa429.

Rerun of atm_jjob after 62f2833 shows that all atm_jjob tests Passed.

RussTreadon-NOAA · 2026-03-04T20:41:51Z

Thank you @DavidHuber-NOAA for the review and approval.

I am currently running GDASApp CI inside g-w PR #4571 on Gaea C6, Hera, Hercules, Orion, Ursa, and WCOSS2 (Dogwood). Pending Passed GDASApp CI results on these machines, I'll move onto g-w CI.

DavidHuber-NOAA · 2026-03-04T20:43:15Z

Noting that this at least partially resolves #2077. It looks like there may still be some soca references to declare_from_tmpl (not suggesting those need to get incorporated into this PR).

DavidHuber-NOAA · 2026-03-04T21:20:21Z

Thanks for addressing those additional declare_from_tmpl changes @RussTreadon-NOAA! It looks like that's all of them.

RussTreadon-NOAA · 2026-03-04T21:25:36Z

GDASApp CI

Install feature/varbc at e4aa429 inside g-w CoryMartin-NOAA:feature/varbc at `90372a6f on Gaea C6, Hera, Hercules, Orion, Ursa, and WCOSS2 (Dogwood). Run GDASApp CI including select g-w CI with the following results

Gaea C6

Test project /gpfs/f6/ira-sti/scratch/Russ.Treadon/git/global-workflow/pr4571/sorc/gdas.cd/build
        Start 271: test_gdasapp_C96C48_ufsgsi_hybatmDA
        Start 293: test_gdasapp_C48_ufsenkf_atmDA
        Start 229: test_gdasapp_C96C48_hybatmDA
        Start 248: test_gdasapp_C96C48_ufs_hybatmDA
        Start 323: test_gdasapp_C96C48_hybatmsnowDA
        Start 307: test_gdasapp_C96_gcafs_cycled
        Start 355: test_gdasapp_C48mx500_hybAOWCDA
        Start 344: test_gdasapp_C48mx500_3DVarAOWCDA
        Start 370: test_gdasapp_setup_atm_jjob_cycled_exp
        Start 369: test_gdasapp_convert_gsi_satbias
        Start 225: test_gdasapp_check_python_norms
        Start 228: test_gdasapp_snow_create_ens
  1/158 Test #370: test_gdasapp_setup_atm_jjob_cycled_exp ...................................   Passed    0.59 sec
        Start 375: test_gdasapp_atm_jjob_ens_init
  2/158 Test #228: test_gdasapp_snow_create_ens .............................................   Passed    0.65 sec
...
157/158 Test #336: test_gdasapp_C96C48_hybatmsnowDA_gdas_fcst_202112201800 ..................   Passed  301.70 sec
158/158 Test #343: test_gdasapp_C96C48_hybatmsnowDA_enkfgdas_fcst_202112201800 ..............   Passed  188.34 sec

100% tests passed, 0 tests failed out of 158

Label Time Summary:
gdasapp    = 22308.58 sec*proc (152 tests)
script     = 22308.58 sec*proc (152 tests)

Total Test time (real) = 2675.71 sec

Hera

Test project /scratch3/NCEPDEV/da/Russ.Treadon/git/global-workflow/pr4571/sorc/gdas.cd/build
        Start 221: test_gdasapp_C96C48_ufsgsi_hybatmDA
        Start 243: test_gdasapp_C48_ufsenkf_atmDA
        Start 179: test_gdasapp_C96C48_hybatmDA
        Start 198: test_gdasapp_C96C48_ufs_hybatmDA
        Start 257: test_gdasapp_C96_gcafs_cycled
        Start 273: test_gdasapp_C96C48_hybatmsnowDA
        Start 294: test_gdasapp_C48mx500_3DVarAOWCDA
        Start 305: test_gdasapp_C48mx500_hybAOWCDA
        Start 320: test_gdasapp_setup_atm_jjob_cycled_exp
        Start 175: test_gdasapp_check_python_norms
        Start 176: test_gdasapp_check_yaml_keys
        Start 177: test_gdasapp_jcb_installation
  1/158 Test #176: test_gdasapp_check_yaml_keys .............................................   Passed    0.13 sec
        Start 178: test_gdasapp_snow_create_ens
  2/158 Test #177: test_gdasapp_jcb_installation ............................................   Passed    0.69 sec
...
157/158 Test #293: test_gdasapp_C96C48_hybatmsnowDA_enkfgdas_fcst_202112201800 ..............   Passed  286.05 sec
158/158 Test #256: test_gdasapp_C48_ufsenkf_atmDA_enkfgdas_fcst_202402240000 ................   Passed  242.13 sec

100% tests passed, 0 tests failed out of 158

Label Time Summary:
gdasapp    = 51468.45 sec*proc (152 tests)
script     = 51468.45 sec*proc (152 tests)

Total Test time (real) = 5027.09 sec

Hercules

Test project /work2/noaa/da/rtreadon/git/global-workflow/hercules/pr4571/sorc/gdas.cd/build
        Start 221: test_gdasapp_C96C48_ufsgsi_hybatmDA
        Start 179: test_gdasapp_C96C48_hybatmDA
        Start 198: test_gdasapp_C96C48_ufs_hybatmDA
        Start 257: test_gdasapp_C96_gcafs_cycled
        Start 273: test_gdasapp_C96C48_hybatmsnowDA
        Start 294: test_gdasapp_C48mx500_3DVarAOWCDA
        Start 305: test_gdasapp_C48mx500_hybAOWCDA
        Start 320: test_gdasapp_setup_atm_jjob_cycled_exp
        Start 175: test_gdasapp_check_python_norms
        Start 176: test_gdasapp_check_yaml_keys
        Start 177: test_gdasapp_jcb_installation
        Start 178: test_gdasapp_snow_create_ens
  1/144 Test #176: test_gdasapp_check_yaml_keys .............................................   Passed    0.13 sec
        Start 319: test_gdasapp_convert_gsi_satbias
  2/144 Test #177: test_gdasapp_jcb_installation ............................................   Passed    0.51 sec
...
143/144 Test #330: test_gdasapp_atm_jjob_ens_inc ............................................   Passed   42.21 sec
        Start 331: test_gdasapp_atm_jjob_ens_final
144/144 Test #331: test_gdasapp_atm_jjob_ens_final ..........................................   Passed   42.18 sec

100% tests passed, 0 tests failed out of 144

Label Time Summary:
gdasapp    = 17174.25 sec*proc (138 tests)
script     = 17174.25 sec*proc (138 tests)

Total Test time (real) = 1925.68 sec

Orion

Test project /work2/noaa/da/rtreadon/git/global-workflow/orion/pr4571/sorc/gdas.cd/build
        Start 221: test_gdasapp_C96C48_ufsgsi_hybatmDA
        Start 179: test_gdasapp_C96C48_hybatmDA
        Start 198: test_gdasapp_C96C48_ufs_hybatmDA
        Start 257: test_gdasapp_C96_gcafs_cycled
        Start 273: test_gdasapp_C96C48_hybatmsnowDA
        Start 294: test_gdasapp_C48mx500_3DVarAOWCDA
        Start 305: test_gdasapp_C48mx500_hybAOWCDA
        Start 320: test_gdasapp_setup_atm_jjob_cycled_exp
        Start 175: test_gdasapp_check_python_norms
        Start 176: test_gdasapp_check_yaml_keys
        Start 177: test_gdasapp_jcb_installation
        Start 178: test_gdasapp_snow_create_ens
  1/144 Test #176: test_gdasapp_check_yaml_keys .............................................   Passed    0.25 sec
        Start 319: test_gdasapp_convert_gsi_satbias
  2/144 Test #177: test_gdasapp_jcb_installation ............................................   Passed    0.83 sec
...
143/144 Test #197: test_gdasapp_C96C48_hybatmDA_enkfgdas_fcst_202112210000 ..................   Passed  326.94 sec
144/144 Test #191: test_gdasapp_C96C48_hybatmDA_gdas_fcst_202112210000 ......................   Passed  551.44 sec

100% tests passed, 0 tests failed out of 144

Label Time Summary:
gdasapp    = 30122.79 sec*proc (138 tests)
script     = 30122.79 sec*proc (138 tests)

Total Test time (real) = 3481.09 sec

Ursa

Test project /scratch3/NCEPDEV/da/Russ.Treadon/git/global-workflow/ursa/pr4571/sorc/gdas.cd/build
        Start 221: test_gdasapp_C96C48_ufsgsi_hybatmDA
        Start 243: test_gdasapp_C48_ufsenkf_atmDA
        Start 179: test_gdasapp_C96C48_hybatmDA
        Start 198: test_gdasapp_C96C48_ufs_hybatmDA
        Start 257: test_gdasapp_C96_gcafs_cycled
        Start 273: test_gdasapp_C96C48_hybatmsnowDA
        Start 294: test_gdasapp_C48mx500_3DVarAOWCDA
        Start 305: test_gdasapp_C48mx500_hybAOWCDA
        Start 320: test_gdasapp_setup_atm_jjob_cycled_exp
        Start 175: test_gdasapp_check_python_norms
        Start 176: test_gdasapp_check_yaml_keys
        Start 177: test_gdasapp_jcb_installation
  1/158 Test #176: test_gdasapp_check_yaml_keys .............................................   Passed    0.09 sec
        Start 178: test_gdasapp_snow_create_ens
  2/158 Test #177: test_gdasapp_jcb_installation ............................................   Passed    0.57 sec
...
156/158 Test #286: test_gdasapp_C96C48_hybatmsnowDA_gdas_fcst_202112201800 ..................   Passed  340.96 sec
157/158 Test #293: test_gdasapp_C96C48_hybatmsnowDA_enkfgdas_fcst_202112201800 ..............   Passed  457.83 sec
158/158 Test #197: test_gdasapp_C96C48_hybatmDA_enkfgdas_fcst_202112210000 ..................   Passed  518.74 sec

100% tests passed, 0 tests failed out of 158

Label Time Summary:
gdasapp    = 91594.99 sec*proc (152 tests)
script     = 91594.99 sec*proc (152 tests)

Total Test time (real) = 8316.22 sec

WCOSS2 (Dogwood)

Test project /lfs/h2/emc/da/noscrub/russ.treadon/git/global-workflow/pr4571/sorc/gdas.cd/build
        Start 221: test_gdasapp_C96C48_ufsgsi_hybatmDA
        Start 243: test_gdasapp_C48_ufsenkf_atmDA
        Start 179: test_gdasapp_C96C48_hybatmDA
        Start 198: test_gdasapp_C96C48_ufs_hybatmDA
        Start 273: test_gdasapp_C96C48_hybatmsnowDA
        Start 257: test_gdasapp_C96_gcafs_cycled
        Start 305: test_gdasapp_C48mx500_hybAOWCDA
        Start 294: test_gdasapp_C48mx500_3DVarAOWCDA
        Start 320: test_gdasapp_setup_atm_jjob_cycled_exp
        Start 319: test_gdasapp_convert_gsi_satbias
        Start 175: test_gdasapp_check_python_norms
        Start 178: test_gdasapp_snow_create_ens
  1/158 Test #175: test_gdasapp_check_python_norms ..........................................   Passed    3.26 sec
        Start 177: test_gdasapp_jcb_installation
  2/158 Test #320: test_gdasapp_setup_atm_jjob_cycled_exp ...................................   Passed    3.60 sec
...
157/158 Test #331: test_gdasapp_atm_jjob_ens_final ..........................................   Passed   53.99 sec
158/158 Test #293: test_gdasapp_C96C48_hybatmsnowDA_enkfgdas_fcst_202112201800 ..............   Passed  505.84 sec

100% tests passed, 0 tests failed out of 158

Label Time Summary:
gdasapp    = 37064.21 sec*proc (152 tests)
script     = 37064.21 sec*proc (152 tests)

Total Test time (real) = 3536.50 sec

All GDASApp ctest including select g-w CI Passed on each machine.

NOTE: Hercules and Orion run fewer ctests because C48_ufsenkf_atmDA is not enabled on MSU machines.

change varbc names

6e28b7d

CoryMartin-NOAA requested review from ADCollard, DavidNew-NOAA and RussTreadon-NOAA February 19, 2026 18:27

DavidNew-NOAA previously approved these changes Feb 19, 2026

View reviewed changes

This was referenced Feb 19, 2026

Supplement rad_varbc_params file with new varbc_params file NOAA-EMC/global-workflow#4570

Closed

Change VarBC names for JEDI NOAA-EMC/global-workflow#4571

Open

ADCollard previously approved these changes Feb 20, 2026

View reviewed changes

Merge branch 'develop' into feature/varbc

3849e19

update names of JEDI varbc tarball and files

372a110

RussTreadon-NOAA dismissed stale reviews from ADCollard and DavidNew-NOAA via 372a110 March 4, 2026 17:09

CoryMartin-NOAA requested review from ADCollard, DavidHuber-NOAA and DavidNew-NOAA March 4, 2026 17:44

RussTreadon-NOAA and others added 2 commits March 4, 2026 18:13

replace declare_from_tmpl with declare in atm_jjob init scripts

62f2833

correct typo in name of varbc tarball for atm_jjob init jobs

e4aa429

DavidHuber-NOAA previously approved these changes Mar 4, 2026

View reviewed changes

remove declare_from_tmpl from aero var_init and soca run_jjobs (#2077)

a57e65b

RussTreadon-NOAA dismissed DavidHuber-NOAA’s stale review via a57e65b March 4, 2026 21:15

RussTreadon-NOAA mentioned this pull request Mar 4, 2026

Remove or update declare_from_tmpl from test/(atm|aero)/global-workflow/jjob_var_init.sh #2077

Open

correct com path in soca run_jjobs.py (#2077)

6eb65cc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make varbc file names more generic#2071

Make varbc file names more generic#2071
CoryMartin-NOAA wants to merge 7 commits intodevelopfrom
feature/varbc

CoryMartin-NOAA commented Feb 19, 2026

Uh oh!

RussTreadon-NOAA commented Mar 4, 2026

Uh oh!

RussTreadon-NOAA commented Mar 4, 2026

Uh oh!

RussTreadon-NOAA commented Mar 4, 2026

Uh oh!

DavidHuber-NOAA commented Mar 4, 2026

Uh oh!

DavidHuber-NOAA commented Mar 4, 2026

Uh oh!

RussTreadon-NOAA commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

CoryMartin-NOAA commented Feb 19, 2026

Description

Companion PRs

Issues

Automated CI tests to run in Global Workflow

Uh oh!

RussTreadon-NOAA commented Mar 4, 2026

Uh oh!

RussTreadon-NOAA commented Mar 4, 2026

Uh oh!

RussTreadon-NOAA commented Mar 4, 2026

Uh oh!

DavidHuber-NOAA commented Mar 4, 2026

Uh oh!

DavidHuber-NOAA commented Mar 4, 2026

Uh oh!

RussTreadon-NOAA commented Mar 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants