Skip to content

[WIP] Remove mean F value calculation for selectivity curve#18

Closed
Copilot wants to merge 11 commits intomainfrom
copilot/vscode-mltl84o7-cc5n
Closed

[WIP] Remove mean F value calculation for selectivity curve#18
Copilot wants to merge 11 commits intomainfrom
copilot/vscode-mltl84o7-cc5n

Conversation

Copy link

Copilot AI commented Feb 19, 2026

Cloud agent has begun work on In `generate_selecti... and will update this pull request as work progresses.

Original prompt

In generate_selectivity_curve.R, don't calculate mean F values for each functional group for the year-month combinations. Extract F at age vector for each year-month combination and generate selectivity parameters. 

Created from VS Code.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 11 commits February 2, 2026 17:53
Co-authored-by: Bai-Li-NOAA <59936250+Bai-Li-NOAA@users.noreply.github.com>
Co-authored-by: Bai-Li-NOAA <59936250+Bai-Li-NOAA@users.noreply.github.com>
Co-authored-by: Bai-Li-NOAA <59936250+Bai-Li-NOAA@users.noreply.github.com>
…features

Co-authored-by: Bai-Li-NOAA <59936250+Bai-Li-NOAA@users.noreply.github.com>
Co-authored-by: Bai-Li-NOAA <59936250+Bai-Li-NOAA@users.noreply.github.com>
Co-authored-by: Bai-Li-NOAA <59936250+Bai-Li-NOAA@users.noreply.github.com>
…ll inflection variables

Co-authored-by: Bai-Li-NOAA <59936250+Bai-Li-NOAA@users.noreply.github.com>
- Removed inst/selectivity_curves_guide.md (content integrated into function docs)
- Made fit_*_selectivity() documentation generic (not fishing-mortality-specific)
- Removed @author fields from all roxygen documentation
- Split tests into test-fit_selectivity_helpers.R and test-generate_selectivity_curve.R
- Changed real EWE test to use menhaden instead of dogfish
- Added validation tests that verify parameter recovery from known true values

Co-authored-by: Bai-Li-NOAA <59936250+Bai-Li-NOAA@users.noreply.github.com>
Co-authored-by: Bai-Li-NOAA <59936250+Bai-Li-NOAA@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants