Skip to content

Changing submodule names to reflect new repository names#179

Open
fmalatino wants to merge 5 commits intoNOAA-GFDL:developfrom
fmalatino:name_change
Open

Changing submodule names to reflect new repository names#179
fmalatino wants to merge 5 commits intoNOAA-GFDL:developfrom
fmalatino:name_change

Conversation

@fmalatino
Copy link
Contributor

Description
This PR changes the .gitmodules file to match the new names for the pyFV3 and pySHiELD submodules. Previously the container build test was failing due to the conflict in names.

How Has This Been Tested?
Tested using currently implemented workflows.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

Copy link
Collaborator

@jjuyeonkim jjuyeonkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the pyFV3 linting, it looks okay to me.

@fmalatino fmalatino requested a review from jjuyeonkim February 17, 2026 16:52
pace/registry.py Outdated
return register_func

def from_dict(self, config: dict, hooks={}) -> T:
def from_dict(self, config: dict, hooks=None) -> T:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion blocking this, but should we add type hints? In this example, "config" has a type hint, but "hooks" doesn't have it. Also, the return type is the generic "T". However, the from_dict in pace/initialization.py has a from_dict that doesn't specify a return type hint. If we add a hook type hint, I think it might be dict[type, Callable[[Any], Any]] based on https://github.com/konradhalas/dacite/blob/master/dacite/config.py.

@fmalatino fmalatino requested a review from jjuyeonkim February 19, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants