Changing submodule names to reflect new repository names#179
Open
fmalatino wants to merge 5 commits intoNOAA-GFDL:developfrom
Open
Changing submodule names to reflect new repository names#179fmalatino wants to merge 5 commits intoNOAA-GFDL:developfrom
fmalatino wants to merge 5 commits intoNOAA-GFDL:developfrom
Conversation
…g to latest versions
jjuyeonkim
approved these changes
Feb 17, 2026
Collaborator
jjuyeonkim
left a comment
There was a problem hiding this comment.
Besides the pyFV3 linting, it looks okay to me.
jjuyeonkim
reviewed
Feb 19, 2026
pace/registry.py
Outdated
| return register_func | ||
|
|
||
| def from_dict(self, config: dict, hooks={}) -> T: | ||
| def from_dict(self, config: dict, hooks=None) -> T: |
Collaborator
There was a problem hiding this comment.
I don't have a strong opinion blocking this, but should we add type hints? In this example, "config" has a type hint, but "hooks" doesn't have it. Also, the return type is the generic "T". However, the from_dict in pace/initialization.py has a from_dict that doesn't specify a return type hint. If we add a hook type hint, I think it might be dict[type, Callable[[Any], Any]] based on https://github.com/konradhalas/dacite/blob/master/dacite/config.py.
jjuyeonkim
approved these changes
Feb 19, 2026
jjuyeonkim
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the
.gitmodulesfile to match the new names for thepyFV3andpySHiELDsubmodules. Previously the container build test was failing due to the conflict in names.How Has This Been Tested?
Tested using currently implemented workflows.
Checklist: