Conversation
christinaholtNOAA
left a comment
There was a problem hiding this comment.
I'm concerned about the tracker pointing to a commit on a feature branch in a repo that we do not control. We cannot ensure the hash will be available indefinitely as opposed to say a hash on a main or develop branch. Perhaps we should keep a fork for GSL and point to the hash there instead.
scripts/run_tracker.sh
Outdated
| @@ -0,0 +1,268 @@ | |||
| #! /bin/bash | |||
There was a problem hiding this comment.
During the 2024 HFIP experiment, the tracker was added using a driver supported in the MPAS App (here). I don't mind having the grib2 pieces in the bash, but I do think that configuring and running the tracker should use the UW Driver framework that was already established for this task.
parm/wflow/tracker.yaml
Outdated
| MPICMD="{{ tracker.execution.mpicmd }} | ||
| FHOUR_STEP="{{ tracker.execution.fhour_step }}" | ||
| FORECAST_LENGTH="{{ forecast.mpas.length }}" | ||
| &MPAS_APP;/scripts/run_tracker.sh @Y@m@d@H' |
There was a problem hiding this comment.
We generally do not use environment variables to define the interface for run scripts in the app. Command line arguments are used for the run-time specific information (cycle and lead time, for example), while the experiment invariant values are pulled explicitly from the experiment YAML. This is preferred for testing and documentation purposes.
There was a problem hiding this comment.
The environment variables have been removed.
I haven't switched to the uw tools tracker driver yet. It's in the PR's "to do" list.
|
Status update. This PR is up to date with main. It doesn't use the uwtools tracker yet since that script is missing two features. From my reading of the scripts, the uwtools tracker lacks two features:
|
Synopsis
This is the second of several PRs to merge improvements from the MPAS HFIP 2025 parallel.
It adds jobs to interpolate to a regular lat-lon grid, a job to run the tracker on that grid, and a job to archive the tracker. (The GFDL Vortex Tracker requires a regular lat-lon grid.)
This is a draft because
Type
Impact
Issues
Dependencies
Checklist