Open
Conversation
added 3 commits
November 1, 2025 00:01
For some reason, the built main.dol doesn't have the same hash though...
Apparently the destructor needs to be explicit, otherwise the function ordering is wrong. Also aligning the slices.
RootCubed
reviewed
Nov 2, 2025
|
|
||
| void dSelectCursor_c::SetAlpha(const nw4r::lyt::Pane *pane, int layoutId) { | ||
| u8 alpha = pane->GetGlbAlpha(); | ||
| Layout_c & layout = mLayouts[layoutId]; |
Collaborator
There was a problem hiding this comment.
Suggested change
| Layout_c & layout = mLayouts[layoutId]; | |
| Layout_c &layout = mLayouts[layoutId]; |
| void SetAlpha(const nw4r::lyt::Pane *pane, int layoutId); | ||
|
|
||
| d2d::ResAccMultLoader_c mResLoader; | ||
| Layout_c mLayouts[5]; |
Collaborator
There was a problem hiding this comment.
Seemingly these 5 layouts all serve a slightly different purpose. Maybe you can add an enum for the 5 layouts and ideally figure out what they're for exactly? This will probably also resolve the int cast needed if you can use LAYOUT_COUNT instead.
| @@ -0,0 +1,239 @@ | |||
| #include <game/bases/d_SelectCursor.hpp> | |||
|
|
|||
| ACTOR_PROFILE(SELECT_CURSOR, dSelectCursor_c, 0); | |||
Collaborator
There was a problem hiding this comment.
Can you test if BASE_PROFILE works too? Otherwise ignore this comment.
| mLayouts[i].mBase.mDrawOrder = 147; | ||
| } | ||
|
|
||
| mLayouts[i].mBase.LoopAnimeStartSetup(0); |
Collaborator
There was a problem hiding this comment.
Suggested change
| mLayouts[i].mBase.LoopAnimeStartSetup(0); | |
| mLayouts[i].mBase.LoopAnimeStartSetup(ANIM_CURSOR); |
These `dSelectCursor_c` symbols are no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.