MM Pytorch API: TabularTransform for input tabular sequence #1161
Draft
MM Pytorch API: TabularTransform for input tabular sequence #1161
Conversation
Documentation preview |
marcromeyn
reviewed
Jun 28, 2023
merlin/models/torch/sequences.py
Outdated
| MASK_PREFIX = "__mask" | ||
|
|
||
|
|
||
| class TabularBatchPadding(nn.Module): |
Contributor
There was a problem hiding this comment.
Should we rename to TabularPadding?
marcromeyn
reviewed
Jun 30, 2023
| MASK_PREFIX = "__mask" | ||
|
|
||
|
|
||
| class TabularPadding(nn.Module): |
Contributor
There was a problem hiding this comment.
I think it might be better to break padding out into a smaller PR first, and then do masking afterwards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
Goals ⚽
- Support multiple targets
- Be used for training, evaluation, and inference
Implementation Details 🚧
TabularBatchPaddingto pad a group of sequential inputsTabularPredictNextfor generating targets of causal next item predictionTabularPredictLastfor generating targets of last item predictionTabularPredictRandomfor generating targets of predicting one random item and truncate the sequence so that the random item is at the last position.TabularMaskRandomfor masked language modeling training (MLM) strategyTabularMaskLastfor masking last item in the sequence, generally used to evaluate models trained with MLM.Testing Details 🔍