Update test config to get postmerge tests running correctly#359
Merged
oliverholworthy merged 14 commits intoNVIDIA-Merlin:mainfrom Jun 5, 2023
Merged
Update test config to get postmerge tests running correctly#359oliverholworthy merged 14 commits intoNVIDIA-Merlin:mainfrom
oliverholworthy merged 14 commits intoNVIDIA-Merlin:mainfrom
Conversation
This is required for horovod init to work correctly
nv-alaiacano
approved these changes
Jun 1, 2023
Contributor
nv-alaiacano
left a comment
nv-alaiacano
left a comment
There was a problem hiding this comment.
CPU postmerge is still failing with a known unrelated issue - feel free to merge this one, which is a step in the right direction.
Don't forget to remove the pull_request: line from the GHA workflows fist.
karlhigley
approved these changes
Jun 1, 2023
Contributor
Author
|
Merged NVIDIA-Merlin/Transformers4Rec#712 which should fix the issue with the discrepancy between traced inputs and expected model inputs (resulted in |
Documentation preview |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update test configuration to get postmerge tests running correctly.