This repository was archived by the owner on Dec 11, 2025. It is now read-only.
Fix Hunk_Alloc() failures in FACENORMALS parsing#511
Merged
apanteleev merged 3 commits intoNVIDIA:masterfrom Dec 10, 2025
Merged
Fix Hunk_Alloc() failures in FACENORMALS parsing#511apanteleev merged 3 commits intoNVIDIA:masterfrom
apanteleev merged 3 commits intoNVIDIA:masterfrom
Conversation
WatIsDeze
added a commit
to PolyhedronStudio/Q2RTXPerimental
that referenced
this pull request
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issues:
FACENORMALSextended BSP lump, a tightly bounded amount of extra memory is requested.However, at runtime, more than that is requested, as (a) allocations may possibly be larger than assumed due to the "round to cacheline" done in
Hunk_TryAlloc(), and (b) multiple allocations happening (each being "round"ed as well).The fixes:
Hunk_TryAlloc()to the extra memory requested for an extended lumpFACENORMALS