refactor: update StridedMemoryView.from_buffer to accept tuples and dtype instead of now-private _StridedLayout
#1380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/ok to test |
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This comment has been minimized.
This comment has been minimized.
leofang
reviewed
Dec 16, 2025
leofang
added
enhancement
… dtype instead of now-private `_StridedLayout`
…ng consistency checks
cpcloud
force-pushed
the
change-from-buffer-signature
branch
from
a289de6 to
b54f628
Compare
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Member
|
LGTM! One question: There are still a few references to I think we should at least comment out |
Contributor
Author
|
Let me see if making |
Member
|
yeah if it's too much churn then let's just raise a warning if users try to access it |
Contributor
Author
|
/ok to test |
Contributor
Author
|
I removed I think all public references to |
leofang
approved these changes
Dec 16, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the definition of
StridedMemoryView.from_bufferto accept shape, strides, and order to match the functionality of_StridedLayoutwithout exposing it in the public API.