Skip to content

Fix exception clauses in Buffer.fill helpers #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andy-Jost merged 3 commits into from
Dec 16, 2025
Merged

Fix exception clauses in Buffer.fill helpers #1381

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9dca3e
Fix exception clauses in Buffer.fill helpers
Andy-Jost Dec 16, 2025
881fba8
Merge branch 'main' into fix-cython-except-clauses
Andy-Jost Dec 16, 2025
0a07bad
Merge branch 'main' into fix-cython-except-clauses
Andy-Jost Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cuda_core/cuda/core/experimental/_memory/_buffer.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,14 +383,15 @@ cdef inline void Buffer_close(Buffer self, stream):
self._alloc_stream = None


cdef inline void Buffer_fill_uint8(Buffer self, uint8_t value, cydriver.CUstream s):
cdef inline int Buffer_fill_uint8(Buffer self, uint8_t value, cydriver.CUstream s) except? -1:
with nogil:
HANDLE_RETURN(cydriver.cuMemsetD8Async(<cydriver.CUdeviceptr>self._ptr, value, self._size, s))
return 0


cdef inline void Buffer_fill_from_ptr(
cdef inline int Buffer_fill_from_ptr(
Buffer self, const char* ptr, size_t width, cydriver.CUstream s
) except *:
) except? -1:
cdef size_t buffer_size = self._size

if width == 1:
Expand All @@ -411,6 +412,7 @@ cdef inline void Buffer_fill_from_ptr(
<cydriver.CUdeviceptr>self._ptr, (<uint32_t*>ptr)[0], buffer_size // 4, s))
else:
raise ValueError(f"value must be 1, 2, or 4 bytes, got {width}")
return 0


cdef Buffer_init_mem_attrs(Buffer self):
Expand Down
Loading