-
Notifications
You must be signed in to change notification settings - Fork 242
chore: move to default envs #1414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
|
Does this mean that there is no longer a cu13 environment? Or did we made cu13 the default? @cpcloud |
|
I got rid of cu13 to avoid some duplication, but I can easily bring it back. |
I think we should bring it back so the name Indeed we should make it the default so users aren't required to type it. If users type nothing, |
5b82e1e to
4ae53fd
Compare
|
/ok to test |
1 similar comment
|
/ok to test |
|
@rparolin I brought back |
1b8c222 to
d7ea6a2
Compare
|
/ok to test |
| [workspace.build-variants] | ||
| python = ["3.10.*", "3.11.*", "3.12.*", "3.13.*", "3.14.*"] | ||
|
|
||
| [dependencies] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was this even doing before? cuda-core was a dependency of itself? 🤔
|
|
||
| [environments] | ||
| cu12 = { features = ["cu12"] } | ||
| cu13 = { features = ["cu13"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want to keep cu13 environment?
|
/ok to test |
|
This PR replaces cu13 environments with
default, allowingpixi run testto work everywhere incuda-python, using cuda 13.x