Skip to content

Conversation

@cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Dec 19, 2025

This PR replaces cu13 environments with default, allowing pixi run test to work everywhere in cuda-python, using cuda 13.x

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Dec 19, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cpcloud cpcloud requested a review from rparolin December 19, 2025 17:52
@cpcloud
Copy link
Contributor Author

cpcloud commented Dec 19, 2025

/ok to test

@github-actions

This comment has been minimized.

@rparolin
Copy link
Collaborator

rparolin commented Dec 19, 2025

Does this mean that there is no longer a cu13 environment? Or did we made cu13 the default? @cpcloud

@cpcloud
Copy link
Contributor Author

cpcloud commented Dec 19, 2025

I got rid of cu13 to avoid some duplication, but I can easily bring it back.

@rparolin
Copy link
Collaborator

I got rid of cu13 to avoid some duplication, but I can easily bring it back.

I think we should bring it back so the name cu13 exists. We will have to use it directly when cu14 is the new default and we want to do cu13 specific testing. So I don't see any harm is having the name being available.

Indeed we should make it the default so users aren't required to type it. If users type nothing, pixi run test then they should get the default we centrally control which at the time of writing is cu13.

@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 6, 2026

/ok to test

1 similar comment
@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 6, 2026

/ok to test

@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 6, 2026

@rparolin I brought back cu13. Would you mind reviewing again?

@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 6, 2026

/ok to test

[workspace.build-variants]
python = ["3.10.*", "3.11.*", "3.12.*", "3.13.*", "3.14.*"]

[dependencies]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was this even doing before? cuda-core was a dependency of itself? 🤔


[environments]
cu12 = { features = ["cu12"] }
cu13 = { features = ["cu13"] }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to keep cu13 environment?

@cpcloud
Copy link
Contributor Author

cpcloud commented Jan 6, 2026

/ok to test

@cpcloud cpcloud enabled auto-merge (squash) January 6, 2026 19:20
@cpcloud cpcloud merged commit dfd4aff into NVIDIA:main Jan 6, 2026
79 of 80 checks passed
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Doc Preview CI
Preview removed because the pull request was closed or merged.

@cpcloud cpcloud deleted the pixi-default-env branch January 6, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants