Skip to content

cuda.bindings.nvml: Correctly handle a test requiring root #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdboom merged 1 commit into from
Jan 24, 2026
Merged

cuda.bindings.nvml: Correctly handle a test requiring root #1515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions cuda_bindings/tests/nvml/test_compute_mode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: LicenseRef-NVIDIA-SOFTWARE-LICENSE


Expand All @@ -25,8 +25,11 @@ def test_compute_mode_supported_nonroot(all_devices):
continue

for cm in COMPUTE_MODES:
with pytest.raises(nvml.NoPermissionError):
try:
nvml.device_set_compute_mode(device, cm)
except nvml.NoPermissionError:
skip_reasons.add(f"nvmlDeviceSetComputeMode requires root for device {device}")
Copy link
Member

@leofang leofang Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how this got passed the CI, but it failed on main:

                except nvml.NoPermissionError:
>                   skip_reasons.add(f"nvmlDeviceSetComputeMode requires root for device {device}")
                    ^^^^^^^^^^^^
E                   NameError: name 'skip_reasons' is not defined

https://github.com/NVIDIA/cuda-python/actions/runs/21307037717/job/61337052365#step:26:510

continue
assert original_compute_mode == nvml.device_get_compute_mode(device), "Compute mode shouldn't have changed"

if skip_reasons:
Expand Down
Loading