Skip to content

Fix #1531 and slightly enhance skip reporting #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rwgk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #1531 and slightly enhance skip reporting #1532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions cuda_bindings/tests/nvml/test_compute_mode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

@pytest.mark.skipif(sys.platform == "win32", reason="Test not supported on Windows")
def test_compute_mode_supported_nonroot(all_devices):
skipped_devices = {} # Using dict (not set) to preserve insertion order.
for device in all_devices:
with unsupported_before(device, None):
original_compute_mode = nvml.device_get_compute_mode(device)
Expand All @@ -26,6 +27,14 @@ def test_compute_mode_supported_nonroot(all_devices):
try:
nvml.device_set_compute_mode(device, cm)
except nvml.NoPermissionError:
skip_reasons.add(f"nvmlDeviceSetComputeMode requires root for device {device}")
continue
assert original_compute_mode == nvml.device_get_compute_mode(device), "Compute mode shouldn't have changed"
skipped_devices[str(device)] = 1 # value is not used.
else:
nvml.device_set_compute_mode(device, original_compute_mode)
assert original_compute_mode == nvml.device_get_compute_mode(device), (
"Compute mode shouldn't have changed"
)

if skipped_devices:
pytest.skip(
f"nvmlDeviceSetComputeMode requires root for {len(skipped_devices)} device(s): {', '.join(skipped_devices)}"
)
Loading