Skip to content

Conversation

@isVoid
Copy link
Collaborator

@isVoid isVoid commented Jan 24, 2026

This PR fixes doc-build that's currently failing in main.

Summary by CodeRabbit

  • Chores
    • Documentation build now runs in an isolated Conda environment to ensure consistent dependency management and build reproducibility; build steps and invocations were migrated to run inside this environment and installed packages are now displayed post-setup.
    • Style checks updated to install required system tooling (e.g., compiler) and pre-commit dependencies so verification runs reliably.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 24, 2026

📝 Walkthrough

Walkthrough

Isolates the documentation build in a new named conda environment docs-build (Python 3.12), moves all docs build and install commands to run inside that environment, adds CUDA runtime and a package-list verification step, and adds apt-get update + apt-get install g++ before installing pre-commit in the style-check script.

Changes

Cohort / File(s) Summary
Documentation Build Environment
.github/actions/docs-build/action.yml
Adds creation of a docs-build conda env (Python 3.12); installs build deps (including cuda-cudart) into it; changes pip and script invocations to conda run -n docs-build ...; adds step to print installed packages; updates docs build trigger to run inside the env; keeps final move step but invoked via conda run.
Style Check Dependencies
ci/check_style.sh
Adds apt-get update and apt-get install g++ before pip install pre-commit to ensure required build tooling for pre-commit hooks.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 In a burrow of conda I hop and hide,

Python 3.12 snug by my side.
CUDA and packages neatly arrayed,
g++ for style checks, no tool delayed.
Hooray — docs build cozy, tests well-played! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Adhoc Doc Build Fix' is vague and generic, using non-descriptive terms that don't clearly convey the specific nature of the documentation build changes. Consider using a more specific title that describes the actual changes, such as 'Create isolated conda environment for documentation build' or 'Add conda environment for docs build with CUDA support'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@isVoid isVoid enabled auto-merge (squash) January 24, 2026 00:12
@isVoid isVoid disabled auto-merge January 24, 2026 00:12
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.github/actions/docs-build/action.yml:
- Line 19: The conda install command "conda install -n docs-build -c conda-forge
clangdev=20 cmake>=3.29 ninja flex bison git c-compiler cxx-compiler make
cuda-cudart" can prompt for confirmation and hang CI; update that command (the
conda install invocation in the action.yml) to include the non-interactive flag
-y so it runs unattended in CI.

@isVoid isVoid enabled auto-merge (squash) January 26, 2026 18:11
@isVoid isVoid merged commit a983ca7 into main Jan 26, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant