Fix flaky multiprocessing cache timing assertion#1385
Open
jioffe502 wants to merge 1 commit intoNVIDIA:mainfrom
Open
Fix flaky multiprocessing cache timing assertion#1385jioffe502 wants to merge 1 commit intoNVIDIA:mainfrom
jioffe502 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
The test_multiple_processes test asserted that each process's second (cached) call was <50% of its first call's duration. When the cross- process cache works correctly, the second process finds p1's result already cached, making both calls sub-millisecond. OS scheduling noise then randomly violates the ratio, causing spurious CI failures. Replace the per-process timing assertion with a check that at least one process actually computed the result (took >=50ms from the sleep), validating the cache works without depending on precise timing ratios. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jacob Ioffe <jioffe@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The test_multiple_processes test asserted that each process's second (cached) call was <50% of its first call's duration. When the cross- process cache works correctly, the second process finds p1's result already cached, making both calls sub-millisecond. OS scheduling noise then randomly violates the ratio, causing spurious CI failures.
fix
Replace the per-process timing assertion with a check that at least one process actually computed the result (took >=50ms from the sleep), validating the cache works without depending on precise timing ratios.
Checklist