Draft
Conversation
Member
Author
c0derMo
reviewed
Jan 18, 2026
|
|
||
| echo "Done. The database has been recreated and is empty." | ||
| echo "You can now run migrations, for example:" | ||
| echo "cd repositories && sqlx migrate run" |
Contributor
There was a problem hiding this comment.
Wouldn't it make more sense to already run the migrations in here?
| ``` | ||
| I would also suggest running it behind a reverse proxy that use ssl. My docker compose setup looks like: | ||
|
|
||
| I recommend deploying InventarWerk behind a reverse proxy with Docker Compose: |
Contributor
There was a problem hiding this comment.
It always felt weird to me that this was written from a singular person's perspective, imo, a plural version ("We recommend..."), or better, a passive way ("It is recommended...")
| ``` | ||
|
|
||
| <details> | ||
| <summary><h2>Initial Requirements</h2></summary> |
Contributor
There was a problem hiding this comment.
I'm not sure if we still need the initial requirements, but if we want to keep them, I'd consider moving them to another file at least
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Readme to represent the changes from the update to postgres.