This repository was archived by the owner on Apr 26, 2020. It is now read-only.
Remove the FactoryModule (replaced by Ninject.Extensions.Factory) and fix unit tests#12
Open
scott-xu wants to merge 3 commits intoNancyFx:masterfrom
Open
Remove the FactoryModule (replaced by Ninject.Extensions.Factory) and fix unit tests#12scott-xu wants to merge 3 commits intoNancyFx:masterfrom
scott-xu wants to merge 3 commits intoNancyFx:masterfrom
Conversation
Contributor
Author
|
This would be a breaking change as user need to refer |
Member
|
I'm not sure I'd classify this a a breaking change. It's just a new dependency and we don't have to change public APIs because of it. The question is; why is it there in the first place? Do we use |
Add Ninject.Extensions.Factory dependency
Contributor
Author
|
@khellang Func is used at least in RouteCache |
Contributor
Author
|
Hi @thecodejunkie @grumpydev, what do you think about this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.