-
Notifications
You must be signed in to change notification settings - Fork 14
Merging with main #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merging with main #141
Changes from all commits
Commits
Show all changes
313 commits
Select commit
Hold shift + click to select a range
e8fddb5
sparger overlap capability
malihass 427f163
add overlapping patches to doc
malihass 6561076
larger image
malihass eff5636
Merge pull request #110 from NREL/strerr
malihass 7b1bfff
update the ci to test python 3.13
malihass 9e0db3b
remove intermediate python tests
malihass 2b950b3
Merge pull request #111 from NREL/pyupdate
malihass c5e1fa6
document ofio
malihass c5b79b2
remove data from package
malihass 26a51f5
add tests for dictionary reading
malihass ac71303
show how to read a control dict
malihass 4134b94
remove too strict assertion
malihass 73e1cb9
format
malihass 587ec49
update version
malihass fd69f6b
remove config files
malihass bac6e15
remove unused imports and format
malihass e5f7f10
docstring for tests
malihass f017303
Merge pull request #112 from NREL/ofio_cleanup
malihass 2511102
centralize postprocess
malihass d0d77b9
test bubble diameter calculation
malihass 1789d0c
remove rogue val dict
malihass 1f7c87c
push to pypi to pass test
malihass 8f7cc18
Merge pull request #113 from NREL/postcleanup
malihass 7069e23
superficial velocity calculation
malihass a139d17
update bird version
malihass 393e338
add flat panel reactor tutorial and add it to the ci
malihass 4706d99
adding ref and only run 1 timestep
malihass 0b5b7be
Merge pull request #114 from NREL/flat_panel
malihass bdda423
add a better contributing guideline
malihass dc55a82
add description of python interface
malihass 483b731
fix display of python versions
malihass 4baca52
Merge pull request #115 from NREL/pythoninterfacedoc
malihass 5f813a5
syncup
malihass 5b3edf8
remove useless hidden files
malihass f605aff
remove old job script
malihass eb07db5
remove duplicated case
malihass 4af29c5
use path lib instead of in package data
malihass 27c1b43
use post_quantities functions for the history
malihass 4eff33d
format
malihass 025be6a
test everything
malihass b07d600
specify nrel-bird version in ci
malihass 760181b
Merge pull request #104 from NREL/movesparg
malihass f4c04e1
make sure prestep and run fail if any command fails
malihass 8e41c00
fail fast experimental cases
malihass e3f2ee9
we do not use force sign anymore
malihass 66f0c07
add boiler plate post process doc
malihass 5b21d40
replace conv2 with conv in the new read history scripts
malihass 77decd1
do the trap after module load (seems like a lot of failure can happen…
malihass e9beae0
setup logger and init it once
malihass 72c7c73
get rid of verbose argument when just used for printing
malihass 5bb13af
get rid of verbose argument when possible
malihass 50bd7b4
use logger and exception when possible
malihass e865ee3
use logger warning and info instead of doing it by hand
malihass fabda0d
get rid of verbose parameter and use more f strings
malihass d58fae1
Merge pull request #118 from NREL/logger
malihass 9c72a66
Merge pull request #117 from NREL/failfast
malihass babb665
Format sim folder
malihass b4b826e
Merge pull request #120 from NREL/simid
malihass e1598c5
add tutorial for python interface
malihass 260a427
update refs
malihass df48ef1
Merge branch 'main' into postprocessdoc
malihass 8c9ec73
remove camelcase and add doc strings for tutorial
malihass 9834d28
add temporary fix for numpyro
malihass 8075078
correct only for specific jax versions
malihass b097287
Merge pull request #121 from NREL/postprocessdoc
malihass 3521b36
move parsers away from mesh tools
malihass 6d85e23
more parsing occurences
malihass 4096991
remove sys exit in favor of exceptions
malihass 4182340
remove more sys exits
malihass 0890814
dont raise naked Value error when possible
malihass bfb812b
update bird version
malihass a5f9954
Merge pull request #123 from NREL/flexvar2
malihass 0597fe4
integrate automatic species thermo write up
malihass 24c06d0
overwrite
malihass 65df400
include yaml in package and add doc string
malihass 19de4a4
format
malihass b85645d
don't run the stirred tank since it is using nbutanol here
malihass 1a3bd5d
remove rogue breakpoint
malihass 9c4d4f2
modify the yaml file so the loop reactor cases are unchanged
malihass 111ab0a
explicit spec name variable
malihass 5e184c7
extensive tests for spec thermo gen
malihass 40fab3b
missing file for test
malihass efd0628
get rid of nbutanol yaml for now
malihass a02d1d1
fix doc format
malihass 0520ebd
fixing typos and describing the ghost blocks based on convo with Hari
malihass 2860d3d
update vers
malihass e489fd8
Merge pull request #124 from NREL/flexvar3
malihass 97e72d8
add docstrings and clean up camelcase
malihass 6a19c6d
more variable name cleanup and format
malihass 0b93278
add logging of block size
malihass 8a11e8e
add note about pip version
malihass 50c8c90
Merge pull request #125 from NREL/logsmallestblock
malihass 7b5d8f7
add mean statistics calulcation
malihass 9873398
add doc for mean stats
malihass ec0c9f4
add docstring
malihass 690e0f7
remove unused import and add comments in relation to the doc
malihass 96d5125
remove breakpoint
malihass 04a0d30
add the filename prefix we actually read
malihass f3470c5
add mesh reading test
malihass afaa881
test force sign test
malihass 98d22f4
add codecov
malihass fc56671
add codecov badge
malihass 9dbd64a
trigger on pr
malihass fcae18f
Merge pull request #127 from NREL/addcov
malihass 424c15c
fix codecov badge
malihass 1e8f39b
make sure codecov runs
malihass 4e1d1e5
rename codecov workflow
malihass 5fca0f5
fix indent in yml
malihass 6b6e168
link coverage badge to coverage report
malihass efcca11
Merge pull request #126 from NREL/corrstats
malihass 3b68b30
safety check for T0
malihass 1ce942c
remove old tests
malihass 5724a41
fix the uniform vector read
malihass c4bad4d
add uniform vector reading
malihass 2c9a2d0
add uniform vector for test
malihass 7377584
explicit the tuple output types
malihass 46dfe73
fix pypi
malihass 73aad10
Merge pull request #128 from NREL/safet0
malihass b92858d
option to output elsewhere the stl patches
malihass 7a0be3f
update v
malihass 8bdfbac
generate files in temporary directories
malihass 8421de4
Merge pull request #129 from NREL/outtest
malihass 6d4ee18
add autodoc
malihass 3f9e847
fix math formulas
malihass b874d83
fix doc string format for returns
malihass 6887157
use google style doc
malihass 6ce97ac
add autogen rst
malihass 6907a81
generate api doc at gh action time
malihass 4f67242
fix ci
malihass 6fe4a77
Merge pull request #130 from NREL/autodoc
malihass dac6212
better control automatic gen of docs
malihass a24a9ed
force deploy
malihass 34e53dd
pip install bird and then build api doc
malihass 5c27640
Merge pull request #131 from NREL/cleanapilink
malihass c43590b
revert force deploy, and only deploy doc on push
malihass 9608f62
explicit path codecov
malihass 7b36d85
explicit bird only
malihass 17e8a44
absolute path
malihass e809d4d
revert codecov v
malihass b9cb14c
fix syntax of codecov
malihass 8834a88
remove rogue pip upgrade
malihass b41ac7f
remove variations
malihass 831b563
seems like -e is important
malihass 6d98d1b
Merge pull request #132 from NREL/codecovfix
malihass 108dd28
exec on push only
malihass b2d6484
compute gas holdup over liquid only
malihass 5de0834
explicit private functions to cleanup API and handle uniform scalar a…
malihass 74fcdfa
more private functions
malihass 330ebee
more private members
malihass 8c8d63c
document where the uniform field is
malihass 967c324
update pypi
malihass 3691c84
debug log instruction for trouble shoot
malihass 0359410
add debug level set in script
malihass 4507f68
add debug level set in script
malihass fa18c88
remove unused headers for Bird API doc
malihass d66616c
update pypi
malihass 0e2da80
remove useless dict
malihass 6d823ae
fix the superficial gas velocity to make sure we average at a height …
malihass c0f36f5
update doc accordingly
malihass 2ccd586
update version
malihass ebc9832
fix doc string
malihass c6f69b8
remove readMesh calls
malihass 51ae7a2
automatic volume time identification
malihass 2107cd7
test for automatic volume read
malihass 25a47bd
remove camel case
malihass 5f48919
remove more camel case and use case_folder instead of case_path
malihass dcc2bc2
use read cell volumes when possible
malihass 501b775
format
malihass f9c13c4
make sure tutorial runs from anywhere and expose read_field
malihass 5d97b8a
fix pytests
malihass 06f985d
Merge pull request #134 from NREL/flex_mesh
malihass 46d657a
update version
malihass 0a48f46
fix python interface doc
malihass af7e5fd
fix logger so we can switch to debug mode without creating a new logger
malihass d52f64d
format
malihass b7d89fc
fix doc string and use the slicing function for will's script
malihass 9f208af
Merge pull request #133 from NREL/fixgh
malihass bd5e0a1
fix syntax warning
malihass de77fce
handle uniform velocity fields for superfical gas velocity calculation
malihass 74d1a00
explicit empty of field dict
36fd42c
use pv for superficial vel
7a45a49
support paraview for superficial velocity
malihass c76c7cf
update doc string
malihass caf97bc
update install guidelines
malihass 6d142d4
force conda forge channel
malihass 0f32a2a
make sure to run on the conda env
malihass 6c721d4
fix ci
malihass 22a50e9
add test for pv
malihass c299d8a
update pypi
malihass 767d17b
fix doc string
malihass 48a62e3
more exhaustive testing of paraview
malihass 92f662c
fix docstring
malihass 1235230
Merge pull request #135 from NREL/syntwarning
malihass 3452025
read global vars into a dictionary and test
malihass aa66bfc
compute instantaneous kla
malihass c3a9ddd
add instantaneous kla tests and docs
malihass 995e64b
update bird version
malihass 21c0d97
fix units in doc
malihass fdd0b79
fix kla doc
malihass c38ac33
fix the tolerance and improve docs
malihass 8344702
ignore htmlcov in case it was generated
malihass 17355ee
update bird version
malihass ae4e2d5
Merge pull request #136 from NREL/kla_spargerdesign
malihass 5c52777
move python interface tut outside of postprocess
malihass 1948183
do not average kla over alpha liq times cell volume
malihass 1f275c9
adjust tutorial accordingly
malihass 420e9f7
Use T0 from globalVars to define temperature
malihass 505cd5a
Merge pull request #137 from NREL/fix_kla_calc
malihass 324f780
handle missing d.gas
malihass 28cb572
specify units
malihass bba7093
fix argument passed
malihass 6b0b128
force outputting of mu.liquid
malihass cf61a60
read bubble diameter from phaseProperties is needed
malihass db47a17
test passing species as string
malihass 368a9c9
add phase properties for test
malihass dc19482
add kla fitting function
malihass b7ce945
fix the kla test
malihass 2fb5fc6
read molecular weight from case if possible
malihass 38868eb
provide thermo file in test case
malihass 3165e0b
automatic reading of mol weight
malihass 2c5f6b6
adding test for molecular weight reading
malihass 2317131
made sure kla runs with will's case
malihass d281035
more explicit doc string
malihass f214e3e
handle missing mu liq
malihass fc63a38
fix docstring
malihass 0fe313d
Merge pull request #138 from NREL/missingdgas
malihass d5b287f
remove rogue breakpoint
malihass 9ba6254
add test for kla compute
malihass 7755850
explicit doc
malihass afed2e9
Merge pull request #139 from NREL/postfix
malihass e38eaf9
use pathlib instead of makedirs to handle intermediate directory crea…
malihass 387de5a
remove folderManagement and path appends
malihass a45d4ff
print bird on warning
malihass 7ff7515
remove value error warning
malihass 5c01430
remove more bird utilities
malihass 33a92d9
move bissection to mathtools
malihass e9b6b43
consistency func/fun
malihass ef7a482
test size group read and make sure bubble size groups are correctly r…
malihass 15d8998
update version
malihass 123c91b
add a retry in case conda fails
malihass e13e973
add a retry in case conda fails
malihass cb7e6ad
add a retry in case conda fails
malihass d64b534
add a retry in case conda fails
malihass 79bbf48
try with mamba instead
malihass caf77ab
switch everything to mamba
malihass 744ee1a
remove in file tests
malihass 67a1ae6
report 95% confidence
malihass 6943225
cleanup public facing API doc
malihass bcf48d8
update v
malihass 64f7a46
Merge pull request #140 from NREL/cleanup
malihass File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| [codespell] | ||
| skip = None, .git,OFsolvers,tutorial_cases,experimental_cases,build,_build,__pycache__,data_conditional_mean,Figures,assets | ||
| skip = None, .git,OFsolvers,*.pdf, tutorial_cases,experimental_cases,build,_build,__pycache__,data_conditional_mean,Figures,assets,htmlcov | ||
| ignore-words = .github/linters/.codespell-ignore-words |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| name: CodeCov | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ main ] | ||
| paths-ignore: | ||
| - '*.md' | ||
| - '*.rst' | ||
| - 'README*' | ||
| - 'LICENSE' | ||
| - 'docs/**' | ||
|
|
||
| jobs: | ||
| codecov: | ||
| runs-on: ubuntu-latest | ||
| defaults: | ||
| run: | ||
| shell: bash -l {0} | ||
| working-directory: ${{github.workspace}} | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.13' | ||
| cache: 'pip' | ||
|
|
||
| - name: Set up micromamba | ||
| uses: mamba-org/setup-micromamba@v1 | ||
| with: | ||
| environment-name: test-env | ||
| create-args: >- | ||
| python=${{ matrix.python-version }} | ||
| channels: conda-forge | ||
| channel-priority: strict | ||
| cache-downloads: true | ||
| cache-env: true | ||
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| micromamba install --yes -n test-env -c conda-forge paraview | ||
| pip install --upgrade pip | ||
| pip install pytest | ||
| pip install pytest-cov | ||
| pip install -e . | ||
|
|
||
| - name: Generate coverage report | ||
| run: | | ||
| pytest --cov=./ --cov-report=xml:coverage.xml | ||
| - name: Upload coverage to Codecov | ||
|
|
||
| uses: codecov/codecov-action@v5 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| file: ./coverage.xml | ||
| flags: unittests | ||
| env_vars: OS,PYTHON | ||
| name: codecov-umbrella | ||
| fail_ci_if_error: false | ||
| verbose: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -136,3 +136,4 @@ dmypy.json | |
| *.stl | ||
|
|
||
| *.swp | ||
| .vim | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Copilot Autofix
AI 3 months ago
To address this CodeQL warning, we should add an explicit
permissionsblock in the workflow file. Since none of the workflow steps write to the repository or require elevated privileges, the minimum required permission for GITHUB_TOKEN iscontents: read. The best way to fix the problem is to add the following under the workflow's top-level keys, immediately aftername: CodeCovand beforeon:. This will applycontents: readpermissions to all jobs in the workflow unless a more specificpermissionsblock is later added.