Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
313 commits
Select commit Hold shift + click to select a range
e8fddb5
sparger overlap capability
malihass Jun 16, 2025
427f163
add overlapping patches to doc
malihass Jun 16, 2025
6561076
larger image
malihass Jun 16, 2025
eff5636
Merge pull request #110 from NREL/strerr
malihass Jun 17, 2025
7b1bfff
update the ci to test python 3.13
malihass Jun 17, 2025
9e0db3b
remove intermediate python tests
malihass Jun 17, 2025
2b950b3
Merge pull request #111 from NREL/pyupdate
malihass Jun 17, 2025
c5e1fa6
document ofio
malihass Jul 8, 2025
c5b79b2
remove data from package
malihass Jul 8, 2025
26a51f5
add tests for dictionary reading
malihass Jul 8, 2025
ac71303
show how to read a control dict
malihass Jul 8, 2025
4134b94
remove too strict assertion
malihass Jul 8, 2025
73e1cb9
format
malihass Jul 8, 2025
587ec49
update version
malihass Jul 8, 2025
fd69f6b
remove config files
malihass Jul 8, 2025
bac6e15
remove unused imports and format
malihass Jul 9, 2025
e5f7f10
docstring for tests
malihass Jul 9, 2025
f017303
Merge pull request #112 from NREL/ofio_cleanup
malihass Jul 9, 2025
2511102
centralize postprocess
malihass Jul 9, 2025
d0d77b9
test bubble diameter calculation
malihass Jul 9, 2025
1789d0c
remove rogue val dict
malihass Jul 9, 2025
1f7c87c
push to pypi to pass test
malihass Jul 9, 2025
8f7cc18
Merge pull request #113 from NREL/postcleanup
malihass Jul 9, 2025
7069e23
superficial velocity calculation
malihass Jul 9, 2025
a139d17
update bird version
malihass Jul 9, 2025
393e338
add flat panel reactor tutorial and add it to the ci
malihass Jul 9, 2025
4706d99
adding ref and only run 1 timestep
malihass Jul 9, 2025
0b5b7be
Merge pull request #114 from NREL/flat_panel
malihass Jul 9, 2025
bdda423
add a better contributing guideline
malihass Jul 10, 2025
dc55a82
add description of python interface
malihass Jul 10, 2025
483b731
fix display of python versions
malihass Jul 10, 2025
4baca52
Merge pull request #115 from NREL/pythoninterfacedoc
malihass Jul 10, 2025
5f813a5
syncup
malihass Jul 10, 2025
5b3edf8
remove useless hidden files
malihass Jul 10, 2025
f605aff
remove old job script
malihass Jul 10, 2025
eb07db5
remove duplicated case
malihass Jul 10, 2025
4af29c5
use path lib instead of in package data
malihass Jul 10, 2025
27c1b43
use post_quantities functions for the history
malihass Jul 10, 2025
4eff33d
format
malihass Jul 10, 2025
025be6a
test everything
malihass Jul 10, 2025
b07d600
specify nrel-bird version in ci
malihass Jul 10, 2025
760181b
Merge pull request #104 from NREL/movesparg
malihass Jul 10, 2025
f4c04e1
make sure prestep and run fail if any command fails
malihass Jul 15, 2025
8e41c00
fail fast experimental cases
malihass Jul 15, 2025
e3f2ee9
we do not use force sign anymore
malihass Jul 15, 2025
66f0c07
add boiler plate post process doc
malihass Jul 15, 2025
5b21d40
replace conv2 with conv in the new read history scripts
malihass Jul 15, 2025
77decd1
do the trap after module load (seems like a lot of failure can happen…
malihass Jul 15, 2025
e9beae0
setup logger and init it once
malihass Jul 15, 2025
72c7c73
get rid of verbose argument when just used for printing
malihass Jul 15, 2025
5bb13af
get rid of verbose argument when possible
malihass Jul 15, 2025
50bd7b4
use logger and exception when possible
malihass Jul 15, 2025
e865ee3
use logger warning and info instead of doing it by hand
malihass Jul 15, 2025
fabda0d
get rid of verbose parameter and use more f strings
malihass Jul 15, 2025
d58fae1
Merge pull request #118 from NREL/logger
malihass Jul 15, 2025
9c72a66
Merge pull request #117 from NREL/failfast
malihass Jul 18, 2025
babb665
Format sim folder
malihass Jul 21, 2025
b4b826e
Merge pull request #120 from NREL/simid
malihass Jul 22, 2025
e1598c5
add tutorial for python interface
malihass Jul 24, 2025
260a427
update refs
malihass Jul 24, 2025
df48ef1
Merge branch 'main' into postprocessdoc
malihass Jul 24, 2025
8c9ec73
remove camelcase and add doc strings for tutorial
malihass Jul 24, 2025
9834d28
add temporary fix for numpyro
malihass Jul 24, 2025
8075078
correct only for specific jax versions
malihass Jul 24, 2025
b097287
Merge pull request #121 from NREL/postprocessdoc
malihass Jul 24, 2025
3521b36
move parsers away from mesh tools
malihass Jul 29, 2025
6d85e23
more parsing occurences
malihass Jul 29, 2025
4096991
remove sys exit in favor of exceptions
malihass Jul 29, 2025
4182340
remove more sys exits
malihass Jul 29, 2025
0890814
dont raise naked Value error when possible
malihass Jul 29, 2025
bfb812b
update bird version
malihass Jul 29, 2025
a5f9954
Merge pull request #123 from NREL/flexvar2
malihass Jul 29, 2025
0597fe4
integrate automatic species thermo write up
malihass Jul 29, 2025
24c06d0
overwrite
malihass Jul 29, 2025
65df400
include yaml in package and add doc string
malihass Jul 29, 2025
19de4a4
format
malihass Jul 29, 2025
b85645d
don't run the stirred tank since it is using nbutanol here
malihass Jul 29, 2025
1a3bd5d
remove rogue breakpoint
malihass Jul 29, 2025
9c4d4f2
modify the yaml file so the loop reactor cases are unchanged
malihass Jul 29, 2025
111ab0a
explicit spec name variable
malihass Jul 29, 2025
5e184c7
extensive tests for spec thermo gen
malihass Jul 29, 2025
40fab3b
missing file for test
malihass Jul 29, 2025
efd0628
get rid of nbutanol yaml for now
malihass Jul 29, 2025
a02d1d1
fix doc format
malihass Jul 30, 2025
0520ebd
fixing typos and describing the ghost blocks based on convo with Hari
malihass Jul 30, 2025
2860d3d
update vers
malihass Aug 1, 2025
e489fd8
Merge pull request #124 from NREL/flexvar3
malihass Aug 1, 2025
97e72d8
add docstrings and clean up camelcase
malihass Aug 6, 2025
6a19c6d
more variable name cleanup and format
malihass Aug 6, 2025
0b93278
add logging of block size
malihass Aug 6, 2025
8a11e8e
add note about pip version
malihass Aug 6, 2025
50c8c90
Merge pull request #125 from NREL/logsmallestblock
malihass Aug 6, 2025
7b5d8f7
add mean statistics calulcation
malihass Sep 2, 2025
9873398
add doc for mean stats
malihass Sep 2, 2025
ec0c9f4
add docstring
malihass Sep 2, 2025
690e0f7
remove unused import and add comments in relation to the doc
malihass Sep 2, 2025
96d5125
remove breakpoint
malihass Sep 2, 2025
04a0d30
add the filename prefix we actually read
malihass Sep 2, 2025
f3470c5
add mesh reading test
malihass Sep 2, 2025
afaa881
test force sign test
malihass Sep 2, 2025
98d22f4
add codecov
malihass Sep 2, 2025
fc56671
add codecov badge
malihass Sep 2, 2025
9dbd64a
trigger on pr
malihass Sep 2, 2025
fcae18f
Merge pull request #127 from NREL/addcov
malihass Sep 2, 2025
424c15c
fix codecov badge
malihass Sep 2, 2025
1e8f39b
make sure codecov runs
malihass Sep 2, 2025
4e1d1e5
rename codecov workflow
malihass Sep 2, 2025
5fca0f5
fix indent in yml
malihass Sep 2, 2025
6b6e168
link coverage badge to coverage report
malihass Sep 2, 2025
efcca11
Merge pull request #126 from NREL/corrstats
malihass Sep 4, 2025
3b68b30
safety check for T0
malihass Sep 5, 2025
1ce942c
remove old tests
malihass Sep 5, 2025
5724a41
fix the uniform vector read
malihass Sep 5, 2025
c4bad4d
add uniform vector reading
malihass Sep 5, 2025
2c9a2d0
add uniform vector for test
malihass Sep 5, 2025
7377584
explicit the tuple output types
malihass Sep 5, 2025
46dfe73
fix pypi
malihass Sep 5, 2025
73aad10
Merge pull request #128 from NREL/safet0
malihass Sep 5, 2025
b92858d
option to output elsewhere the stl patches
malihass Sep 6, 2025
7a0be3f
update v
malihass Sep 6, 2025
8bdfbac
generate files in temporary directories
malihass Sep 6, 2025
8421de4
Merge pull request #129 from NREL/outtest
malihass Sep 6, 2025
6d4ee18
add autodoc
malihass Sep 6, 2025
3f9e847
fix math formulas
malihass Sep 6, 2025
b874d83
fix doc string format for returns
malihass Sep 6, 2025
6887157
use google style doc
malihass Sep 6, 2025
6ce97ac
add autogen rst
malihass Sep 6, 2025
6907a81
generate api doc at gh action time
malihass Sep 6, 2025
4f67242
fix ci
malihass Sep 6, 2025
6fe4a77
Merge pull request #130 from NREL/autodoc
malihass Sep 6, 2025
dac6212
better control automatic gen of docs
malihass Sep 6, 2025
a24a9ed
force deploy
malihass Sep 6, 2025
34e53dd
pip install bird and then build api doc
malihass Sep 6, 2025
5c27640
Merge pull request #131 from NREL/cleanapilink
malihass Sep 6, 2025
c43590b
revert force deploy, and only deploy doc on push
malihass Sep 6, 2025
9608f62
explicit path codecov
malihass Sep 6, 2025
7b36d85
explicit bird only
malihass Sep 6, 2025
17e8a44
absolute path
malihass Sep 6, 2025
e809d4d
revert codecov v
malihass Sep 6, 2025
b9cb14c
fix syntax of codecov
malihass Sep 6, 2025
8834a88
remove rogue pip upgrade
malihass Sep 6, 2025
b41ac7f
remove variations
malihass Sep 6, 2025
831b563
seems like -e is important
malihass Sep 6, 2025
6d98d1b
Merge pull request #132 from NREL/codecovfix
malihass Sep 6, 2025
108dd28
exec on push only
malihass Sep 6, 2025
b2d6484
compute gas holdup over liquid only
malihass Sep 9, 2025
5de0834
explicit private functions to cleanup API and handle uniform scalar a…
malihass Sep 9, 2025
74fcdfa
more private functions
malihass Sep 9, 2025
330ebee
more private members
malihass Sep 9, 2025
8c8d63c
document where the uniform field is
malihass Sep 9, 2025
967c324
update pypi
malihass Sep 9, 2025
3691c84
debug log instruction for trouble shoot
malihass Sep 9, 2025
0359410
add debug level set in script
malihass Sep 9, 2025
4507f68
add debug level set in script
malihass Sep 9, 2025
fa18c88
remove unused headers for Bird API doc
malihass Sep 9, 2025
d66616c
update pypi
malihass Sep 9, 2025
0e2da80
remove useless dict
malihass Sep 12, 2025
6d823ae
fix the superficial gas velocity to make sure we average at a height …
malihass Sep 12, 2025
c0f36f5
update doc accordingly
malihass Sep 12, 2025
2ccd586
update version
malihass Sep 12, 2025
ebc9832
fix doc string
malihass Sep 12, 2025
c6f69b8
remove readMesh calls
malihass Sep 14, 2025
51ae7a2
automatic volume time identification
malihass Sep 14, 2025
2107cd7
test for automatic volume read
malihass Sep 14, 2025
25a47bd
remove camel case
malihass Sep 14, 2025
5f48919
remove more camel case and use case_folder instead of case_path
malihass Sep 14, 2025
dcc2bc2
use read cell volumes when possible
malihass Sep 14, 2025
501b775
format
malihass Sep 14, 2025
f9c13c4
make sure tutorial runs from anywhere and expose read_field
malihass Sep 14, 2025
5d97b8a
fix pytests
malihass Sep 14, 2025
06f985d
Merge pull request #134 from NREL/flex_mesh
malihass Sep 14, 2025
46d657a
update version
malihass Sep 14, 2025
0a48f46
fix python interface doc
malihass Sep 14, 2025
af7e5fd
fix logger so we can switch to debug mode without creating a new logger
malihass Sep 14, 2025
d52f64d
format
malihass Sep 14, 2025
b7d89fc
fix doc string and use the slicing function for will's script
malihass Sep 15, 2025
9f208af
Merge pull request #133 from NREL/fixgh
malihass Sep 15, 2025
bd5e0a1
fix syntax warning
malihass Sep 16, 2025
de77fce
handle uniform velocity fields for superfical gas velocity calculation
malihass Sep 16, 2025
74d1a00
explicit empty of field dict
Sep 16, 2025
36fd42c
use pv for superficial vel
Sep 16, 2025
7a45a49
support paraview for superficial velocity
malihass Sep 16, 2025
c76c7cf
update doc string
malihass Sep 16, 2025
caf97bc
update install guidelines
malihass Sep 16, 2025
6d142d4
force conda forge channel
malihass Sep 16, 2025
0f32a2a
make sure to run on the conda env
malihass Sep 16, 2025
6c721d4
fix ci
malihass Sep 16, 2025
22a50e9
add test for pv
malihass Sep 16, 2025
c299d8a
update pypi
malihass Sep 16, 2025
767d17b
fix doc string
malihass Sep 16, 2025
48a62e3
more exhaustive testing of paraview
malihass Sep 16, 2025
92f662c
fix docstring
malihass Sep 16, 2025
1235230
Merge pull request #135 from NREL/syntwarning
malihass Sep 17, 2025
3452025
read global vars into a dictionary and test
malihass Sep 22, 2025
aa66bfc
compute instantaneous kla
malihass Sep 22, 2025
c3a9ddd
add instantaneous kla tests and docs
malihass Sep 22, 2025
995e64b
update bird version
malihass Sep 22, 2025
21c0d97
fix units in doc
malihass Sep 22, 2025
fdd0b79
fix kla doc
malihass Sep 23, 2025
c38ac33
fix the tolerance and improve docs
malihass Sep 23, 2025
8344702
ignore htmlcov in case it was generated
malihass Sep 23, 2025
17355ee
update bird version
malihass Sep 23, 2025
ae4e2d5
Merge pull request #136 from NREL/kla_spargerdesign
malihass Sep 23, 2025
5c52777
move python interface tut outside of postprocess
malihass Sep 27, 2025
1948183
do not average kla over alpha liq times cell volume
malihass Sep 27, 2025
1f275c9
adjust tutorial accordingly
malihass Sep 27, 2025
420e9f7
Use T0 from globalVars to define temperature
malihass Sep 27, 2025
505cd5a
Merge pull request #137 from NREL/fix_kla_calc
malihass Sep 27, 2025
324f780
handle missing d.gas
malihass Oct 1, 2025
28cb572
specify units
malihass Oct 1, 2025
bba7093
fix argument passed
malihass Oct 1, 2025
6b0b128
force outputting of mu.liquid
malihass Oct 1, 2025
cf61a60
read bubble diameter from phaseProperties is needed
malihass Oct 1, 2025
db47a17
test passing species as string
malihass Oct 1, 2025
368a9c9
add phase properties for test
malihass Oct 1, 2025
dc19482
add kla fitting function
malihass Oct 2, 2025
b7ce945
fix the kla test
malihass Oct 2, 2025
2fb5fc6
read molecular weight from case if possible
malihass Oct 2, 2025
38868eb
provide thermo file in test case
malihass Oct 2, 2025
3165e0b
automatic reading of mol weight
malihass Oct 2, 2025
2c5f6b6
adding test for molecular weight reading
malihass Oct 2, 2025
2317131
made sure kla runs with will's case
malihass Oct 2, 2025
d281035
more explicit doc string
malihass Oct 2, 2025
f214e3e
handle missing mu liq
malihass Oct 2, 2025
fc63a38
fix docstring
malihass Oct 2, 2025
0fe313d
Merge pull request #138 from NREL/missingdgas
malihass Oct 2, 2025
d5b287f
remove rogue breakpoint
malihass Oct 3, 2025
9ba6254
add test for kla compute
malihass Oct 3, 2025
7755850
explicit doc
malihass Oct 3, 2025
afed2e9
Merge pull request #139 from NREL/postfix
malihass Oct 3, 2025
e38eaf9
use pathlib instead of makedirs to handle intermediate directory crea…
malihass Oct 17, 2025
387de5a
remove folderManagement and path appends
malihass Oct 17, 2025
a45d4ff
print bird on warning
malihass Oct 17, 2025
7ff7515
remove value error warning
malihass Oct 19, 2025
5c01430
remove more bird utilities
malihass Oct 19, 2025
33a92d9
move bissection to mathtools
malihass Oct 19, 2025
e9b6b43
consistency func/fun
malihass Oct 19, 2025
ef7a482
test size group read and make sure bubble size groups are correctly r…
malihass Oct 19, 2025
15d8998
update version
malihass Oct 19, 2025
123c91b
add a retry in case conda fails
malihass Oct 19, 2025
e13e973
add a retry in case conda fails
malihass Oct 19, 2025
cb7e6ad
add a retry in case conda fails
malihass Oct 19, 2025
d64b534
add a retry in case conda fails
malihass Oct 19, 2025
79bbf48
try with mamba instead
malihass Oct 19, 2025
caf77ab
switch everything to mamba
malihass Oct 19, 2025
744ee1a
remove in file tests
malihass Oct 19, 2025
67a1ae6
report 95% confidence
malihass Oct 19, 2025
6943225
cleanup public facing API doc
malihass Oct 19, 2025
bcf48d8
update v
malihass Oct 19, 2025
64f7a46
Merge pull request #140 from NREL/cleanup
malihass Oct 20, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .github/linters/.codespellrc
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[codespell]
skip = None, .git,OFsolvers,tutorial_cases,experimental_cases,build,_build,__pycache__,data_conditional_mean,Figures,assets
skip = None, .git,OFsolvers,*.pdf, tutorial_cases,experimental_cases,build,_build,__pycache__,data_conditional_mean,Figures,assets,htmlcov
ignore-words = .github/linters/.codespell-ignore-words
22 changes: 19 additions & 3 deletions .github/workflows/build_docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ jobs:

build_docs:
runs-on: ubuntu-latest

defaults:
run:
shell: bash -l {0}
working-directory: ${{github.workspace}}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -21,11 +24,24 @@ jobs:
with:
python-version: '3.10'
cache: 'pip'


- name: Set up micromamba
uses: mamba-org/setup-micromamba@v1
with:
environment-name: test-env
create-args: >-
python=${{ matrix.python-version }}
channels: conda-forge
channel-priority: strict
cache-downloads: true
cache-env: true

- name: Install dependencies
run: |
micromamba install --yes -n test-env -c conda-forge paraview
python -m pip install --upgrade pip
pip install sphinx sphinx_rtd_theme
pip install -e .
pip install sphinx sphinx_rtd_theme sphinx-autodoc-typehints

- name: Build documentation
run: |
Expand Down
71 changes: 58 additions & 13 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
- '*.rst'
- 'README*'
- 'LICENSE'
- 'assets/*'
- 'docs/**'

pull_request:
branches: [main]
Expand All @@ -17,7 +17,7 @@ on:
- '*.rst'
- 'README*'
- 'LICENSE'
- 'assets/*'
- 'docs/**'

jobs:
Lint:
Expand All @@ -30,6 +30,7 @@ jobs:
os: ['ubuntu-latest']
defaults:
run:
shell: bash -l {0}
working-directory: ${{github.workspace}}
steps:
- uses: actions/checkout@v4
Expand All @@ -52,30 +53,39 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ['3.10', '3.11', '3.12']
python-version: ['3.10', '3.13']
os: ['ubuntu-latest', 'macos-latest']
defaults:
run:
shell: bash -l {0}
working-directory: ${{github.workspace}}

steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: ${{matrix.python-version}}

- name: Set up micromamba
uses: mamba-org/setup-micromamba@v1
with:
environment-name: test-env
create-args: >-
python=${{ matrix.python-version }}
channels: conda-forge
channel-priority: strict
cache-downloads: true
cache-env: true

- name: Install dependencies
run: |
micromamba install --yes -n test-env -c conda-forge paraview
pip install --upgrade pip
pip install .
pip install .
pip install pytest
- name: Test preprocess
run: |
pytest tests/preprocess
- name: Test mesh
run: |
pytest tests/meshing
- name: Test postprocessing
run: |
pytest tests/postprocess

- name: Test
run: pytest .

Test-pypi-Bird:
name: Test-pypi-BiRD (${{ matrix.python-version }}, ${{ matrix.os }})
Expand All @@ -87,17 +97,32 @@ jobs:
os: ['ubuntu-latest']
defaults:
run:
shell: bash -l {0}
working-directory: ${{github.workspace}}
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: ${{matrix.python-version}}

- name: Set up micromamba
uses: mamba-org/setup-micromamba@v1
with:
environment-name: test-env
create-args: >-
python=${{ matrix.python-version }}
channels: conda-forge
channel-priority: strict
cache-downloads: true
cache-env: true

- name: Install dependencies
run: |
micromamba install --yes -n test-env -c conda-forge paraview
pip install --upgrade pip
pip install nrel-bird
pip install pytest

- name: Test
run: pytest .

Expand All @@ -111,6 +136,7 @@ jobs:
os: ['ubuntu-22.04']
defaults:
run:
shell: bash -l {0}
working-directory: ${{github.workspace}}
steps:
- uses: actions/checkout@v4
Expand All @@ -120,10 +146,24 @@ jobs:
- uses: gerlero/setup-openfoam@v1
with:
openfoam-version: 9

- name: Set up micromamba
uses: mamba-org/setup-micromamba@v1
with:
environment-name: test-env
create-args: >-
python=${{ matrix.python-version }}
channels: conda-forge
channel-priority: strict
cache-downloads: true
cache-env: true

- name: Install dependencies
run: |
micromamba install --yes -n test-env -c conda-forge paraview
pip install --upgrade pip
pip install .

- name: Compile solver
run: |
cd OFsolvers/birdmultiphaseEulerFoam
Expand Down Expand Up @@ -176,4 +216,9 @@ jobs:
cd tutorial_cases/airlift_40m
bash run.sh
cd ../../
- name: Run flat panel reactor tutorial
run: |
cd tutorial_cases/FlatPanel_250L_ASU
bash run.sh
cd ../../

62 changes: 62 additions & 0 deletions .github/workflows/codecov.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
name: CodeCov

on:
push:
branches: [ main ]
paths-ignore:
- '*.md'
- '*.rst'
- 'README*'
- 'LICENSE'
- 'docs/**'

jobs:
codecov:
runs-on: ubuntu-latest
defaults:
run:
shell: bash -l {0}
working-directory: ${{github.workspace}}
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.13'
cache: 'pip'

- name: Set up micromamba
uses: mamba-org/setup-micromamba@v1
with:
environment-name: test-env
create-args: >-
python=${{ matrix.python-version }}
channels: conda-forge
channel-priority: strict
cache-downloads: true
cache-env: true

- name: Install dependencies
run: |
micromamba install --yes -n test-env -c conda-forge paraview
pip install --upgrade pip
pip install pytest
pip install pytest-cov
pip install -e .

- name: Generate coverage report
run: |
pytest --cov=./ --cov-report=xml:coverage.xml
- name: Upload coverage to Codecov

uses: codecov/codecov-action@v5
with:
token: ${{ secrets.CODECOV_TOKEN }}
file: ./coverage.xml
flags: unittests
env_vars: OS,PYTHON
name: codecov-umbrella
fail_ci_if_error: false
verbose: true
Comment on lines +15 to +62

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI 3 months ago

To address this CodeQL warning, we should add an explicit permissions block in the workflow file. Since none of the workflow steps write to the repository or require elevated privileges, the minimum required permission for GITHUB_TOKEN is contents: read. The best way to fix the problem is to add the following under the workflow's top-level keys, immediately after name: CodeCov and before on:. This will apply contents: read permissions to all jobs in the workflow unless a more specific permissions block is later added.

Suggested changeset 1
.github/workflows/codecov.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/codecov.yml b/.github/workflows/codecov.yml
--- a/.github/workflows/codecov.yml
+++ b/.github/workflows/codecov.yml
@@ -1,4 +1,6 @@
 name: CodeCov
+permissions:
+  contents: read
 
 on:
   push:
EOF
@@ -1,4 +1,6 @@
name: CodeCov
permissions:
contents: read

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.
23 changes: 20 additions & 3 deletions .github/workflows/deploy_docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ jobs:

build_deploy_docs:
runs-on: ubuntu-latest
defaults:
run:
shell: bash -l {0}
working-directory: ${{github.workspace}}
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
steps:
Expand All @@ -22,11 +26,24 @@ jobs:
with:
python-version: '3.10'
cache: 'pip'


- name: Set up micromamba
uses: mamba-org/setup-micromamba@v1
with:
environment-name: test-env
create-args: >-
python=${{ matrix.python-version }}
channels: conda-forge
channel-priority: strict
cache-downloads: true
cache-env: true

- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install sphinx sphinx_rtd_theme
micromamba install --yes -n test-env -c conda-forge paraview
pip install --upgrade pip
pip install -e .
pip install sphinx sphinx_rtd_theme sphinx-autodoc-typehints

- name: Build documentation
run: |
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -136,3 +136,4 @@ dmypy.json
*.stl

*.swp
.vim
29 changes: 17 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# <ins>Bi</ins>o <ins>R</ins>eactor <ins>D</ins>esign (BiRD) [![bird-CI](https://github.com/NREL/BioReactorDesign/actions/workflows/ci.yml/badge.svg)](https://github.com/NREL/BioReactorDesign/actions/workflows/ci.yml) [![bird-pyversion](https://img.shields.io/pypi/pyversions/NREL-bird.svg)](https://pypi.org/project/NREL-bird/) [![bird-pypi](https://badge.fury.io/py/nrel-bird.svg)](https://badge.fury.io/py/nrel-bird)
# <ins>Bi</ins>o <ins>R</ins>eactor <ins>D</ins>esign (BiRD) [![bird-CI](https://github.com/NREL/BioReactorDesign/actions/workflows/ci.yml/badge.svg)](https://github.com/NREL/BioReactorDesign/actions/workflows/ci.yml) [![bird-pyversion](https://img.shields.io/pypi/pyversions/NREL-bird.svg)](https://pypi.org/project/NREL-bird/) [![coverage](https://codecov.io/gh/NREL/BioReactorDesign/graph/badge.svg)](https://app.codecov.io/gh/nrel/bioreactordesign) [![bird-pypi](https://badge.fury.io/py/nrel-bird.svg)](https://badge.fury.io/py/nrel-bird)

## Quick start
1. Follow the steps to install the python package (see `Installation of python package for developers` or `Installation of python package for users` below)
Expand All @@ -13,7 +13,7 @@ bash run.sh
## Installation of python package for developers

```bash
conda create --name bird python=3.10
conda create -c conda-forge --name bird python=3.10 paraview
conda activate bird
git clone https://github.com/NREL/BioReactorDesign.git
cd BioReactorDesign
Expand All @@ -23,11 +23,13 @@ pip install -e .
## Installation of python package for users

```bash
conda create --name bird python=3.10
conda create -c conda-forge --name bird python=3.10 paraview
conda activate bird
pip install nrel-bird
pip install nrel-bird=={version}
```

We highly recommend that you specify the version explicitly as the library is still rapidly changing.

## Installation of BiRD OpenFOAM solver (for developers and users)

1. Activate your OpenFOAM-9 environment (`source <OpenFOAM-9 installation directory>/etc/<your-shell>rc`)
Expand All @@ -43,17 +45,20 @@ See the [nrel.github.io/BioReactorDesign](https://nrel.github.io/BioReactorDesig

Software record [SWR 24-35](https://www.osti.gov/biblio/2319227)

To cite BioReactorDesign use these articles on [CO2 interphase mass transfer (open access)](https://arxiv.org/pdf/2404.19636) on [aerobic bioreactors](https://www.sciencedirect.com/science/article/pii/S0263876218304337)
and on [butanediol synthesis](https://www.sciencedirect.com/science/article/pii/S0263876223004689)
To cite BiRD, please use these articles on [CO2 interphase mass transfer](https://doi.org/10.1016/j.cherd.2025.01.034) (open access [link](https://arxiv.org/pdf/2404.19636) ) on [aerobic bioreactors](https://doi.org/10.1016/j.cherd.2018.08.033) and on [butanediol synthesis](https://doi.org/10.1016/j.cherd.2023.07.031)


```
@article{hassanaly2024inverse,
title={Bayesian calibration of bubble size dynamics applied to \ce{CO2} gas fermenters},
author={Hassanaly, Malik and Parra-Alvarez, John M. and Rahimi, Mohammad J. and Sitaraman, Hariswaran},
journal={Under Review},
year={2024},
@article{hassanaly2025bayesian,
title={Bayesian calibration of bubble size dynamics applied to CO2 gas fermenters},
author={Hassanaly, Malik and Parra-Alvarez, John M and Rahimi, Mohammad J and Municchi, Federico and Sitaraman, Hariswaran},
journal={Chemical Engineering Research and Design},
volume={215},
pages={312--328},
year={2025},
publisher={Elsevier}
}


@article{rahimi2018computational,
title={Computational fluid dynamics study of full-scale aerobic bioreactors: Evaluation of gas--liquid mass transfer, oxygen uptake, and dynamic oxygen distribution},
author={Rahimi, Mohammad J and Sitaraman, Hariswaran and Humbird, David and Stickel, Jonathan J},
Expand Down
Loading
Loading