Enable load following optimization dispatch with Pyomo #407

genevievestarke · 2025-12-09T21:11:22Z

Bring Pyomo load following dispatch capabilities into H2I

This feature would enable dispatch optimization using one storage technology and multiple generation technologies (using the combiner) to determine optimal storage operation to follow a load while minimizing costs. This feature adds the optimization problem formulation, framework, and solver for the optimization in Pyomo. To do this, a hybrid_rule.py file was added to aggregate the storage and production variables to create one problem for the optimizer. The added files are

OptimizedDispatchController class in pyomo_controllers.py
The hybrid_rule.py file: Aggregates optimization pieces from the various components and formulates the model for the optimization. This file collects the objective function, initializes model parameters, and updates time series parameters.
The generic_converter_opt.py file: Houses the variables, parameters, constraints, and objective function for the generator technology in the optimization model.
The pyomo_storage_rule_min_operating_cost.py file: houses the storage and system variables, parameters, constraints, and objective function. Ideally the system parameters would be in a separate file, perhaps, but have been combined for efficiency in the first implementation.
The controller_opt_problem_state.py file: Formulates the optimization model for the solver

The below is an example of how and where the dispatch is run using a battery for electricity storage:

Section 1: Type of Contribution

Section 2: Draft PR Checklist

Open draft PR
Describe the feature that will be added
Fill out TODO list steps
Describe requested feedback from reviewers on draft PR
Complete Section 7: New Model Checklist (if applicable)

TODO:

Get general feedback on framework of added pyomo pieces
Apply any framework feedback and update code so that heuristic dispatch works as expected
Update example to accurately describe run
Update doc strings in methods
Write tests for new pyomo optimization
Make docs page?
Maybe: address where dispatch inputs should live for generator technologies
Maybe: make an example with multiple generation technologies, using the combiner to connect to dispatch

Type of Reviewer Feedback Requested (on Draft PR)

Structural feedback:
This dispatch model differs significantly from the heuristic block formulation in H2I. The dispatch for the generation + storage system is aggregated in hybrid_rule.py, which pulls from generic_converter_opt.py and pyomo_storage_rule_min_operating_cost.py, all three of which are classes, and thus outside of the OpenMDAO input/output framework. This was implemented because the previous dispatch_rule framework was difficult to aggregate in the way that was needed to formulate the optimization problem. I would like feedback on this structure, and whether we could make it more OpenMDAO-friendly.

Implementation feedback:

Other feedback:
The inputs to the dispatch are all defined in the storage technology config, including the cost_per_production term, which describes the cost of the production technologies. I think this should be defined under the production technologies in the config, so any feedback on how to pull this into the battery dispatch would be appreciated!

Section 3: General PR Checklist

PR description thoroughly describes the new feature, bug fix, etc.
Added tests for new functionality or bug fixes
Tests pass (If not, and this is expected, please elaborate in the Section 6: Test Results)
Documentation
- Docstrings are up-to-date
- Related docs/ files are up-to-date, or added when necessary
- Documentation has been rebuilt successfully
- Examples have been updated (if applicable)
CHANGELOG.md has been updated to describe the changes made in this PR

Section 3: Related Issues

This resolves #386

Section 4: Impacted Areas of the Software

Section 4.1: New Files

path/to/file.extension
- method1: What and why something was changed in one sentence or less.

Section 4.2: Modified Files

path/to/file.extension
- method1: What and why something was changed in one sentence or less.

Section 5: Additional Supporting Information

Section 6: Test Results, if applicable

Section 7 (Optional): New Model Checklist

{build-extensions,convert,download-extensions,help,install-extras,model-viewer,run,solve,test-solvers} ... This is the main driver for the Pyomo optimization software. options: -h, --help show this help message and exit --version show program's version number and exit subcommands: {build-extensions,convert,download-extensions,help,install-extras,model-viewer,run,solve,test-solvers} build-extensions Build compiled extension modules convert Convert a Pyomo model to another format download-extensions Download compiled extension modules help Print help information. install-extras Install "extra" packages that Pyomo can leverage. model-viewer Run the Pyomo model viewer run Execute a command from the Pyomo bin (or Scripts) directory. solve Optimize a model test-solvers Test Pyomo solvers ------------------------------------------------------------------------- Pyomo supports a variety of modeling and optimization capabilities, which are executed either as subcommands of 'pyomo' or as separate commands. Use the 'help' subcommand to get information about the capabilities installed with Pyomo. Additionally, each subcommand supports independent command-line options. Use the -h option to print details for a subcommand. For example, type pyomo solve -h to print information about the `solve` subcommand. branch that needs to be saved for later

Merging in current pyomo opt branch

…in operating costs framework

…e/H2Integrate into feature/pyomo_opt

genevievestarke · 2025-12-31T21:31:16Z

This pull request is ready for an overall framework review!

elenya-grant

This is super cool new functionality! Thanks for adding this into H2I!

I think eventually (not in this PR) that we may need to consider a framework specific to handling supervisory or plant-level control (rather than technology-level control). But - I think this is a great starting point!

Most of my comments are high-level or are small things that could be updated later. I think that making this flexible to different timesteps, rounding precision, and checking that this can be used for non-electricity commodities would be good future steps to take but not necessarily required at this moment!

I'll review again, but wanted to provide my initial feedback!

elenya-grant · 2026-01-08T17:12:23Z

h2integrate/control/control_rules/pyomo_control_options.py

It doesn't look PyomoControlOptions is being used anywhere?

elenya-grant · 2026-01-08T17:16:09Z

h2integrate/control/control_strategies/pyomo_controllers.py

I almost think it'd be nice to split out these controllers into separate files. Like PyomoControllerBaseConfig and PyomoControllerBaseClass (maybe even SolverOptions if that's used across the Pyomo controllers) could be moved into h2integrate/control/control_strategies/controller_baseclass.py. Then separate files for SimpleBatteryControllerHeuristic, HeuristicLoadFollowingControllerConfig and HeuristicLoadFollowingController, and OptimizedDispatchControllerConfig and OptimizedDispatchController. This could be a separate clean-up thing though and is non-blocking at the moment. But - if you wanted to move OptimizedDispatchControllerConfig and OptimizedDispatchController to a separate file now, that'd also seem good to me :)

elenya-grant · 2026-01-08T17:18:03Z

h2integrate/control/control_rules/hybrid_rule.py

+        # )
+
+        self.source_techs = source_techs
+        self.options = dispatch_options


The only option used in dispatch_options is the time_weighting_factor. Could we replace dispatch_options with time_weighting_factor and then remove the options attribute altogether?

elenya-grant · 2026-01-08T17:18:36Z

h2integrate/control/control_rules/hybrid_rule.py

+        self.arcs = []
+
+        self.block_set_name = block_set_name
+        self.round_digits = 4


could we make round_digits an input that can be user-set at the config level (it could default to 4 if desired)

h2integrate/control/control_strategies/pyomo_controllers.py

elenya-grant · 2026-01-08T17:24:10Z

h2integrate/control/test/test_pyomo_controllers.py

new test for the OptimizedDispatchController would be nice!

elenya-grant · 2026-01-08T18:00:20Z

h2integrate/control/control_strategies/pyomo_controllers.py

+        }
+
+        self.n_control_window = self.config.n_control_window
+        self.n_horizon_window = self.config.n_control_window


why is self.n_control_window and self.n_horizon_window both being set to self.config.n_control_window? Rather than having these as attributes, could we just always access them from the config? It also doesn't seem like self.config.n_horizon_window is used anywhere within the Pyomo classes. I think in OptimizedDispatchController._create_dispatch_optimization_model() the forecast horizon should be set as:

model.forecast_horizon = pyomo.Set( doc="Set of time periods in time horizon", initialize=range(self.config.n_control_window), )

* refactored DispatchProblemState * updated tech config and removed pysam options file * minor cleanups to DispatchProblemState * minor updates to generic_converter_opt * initial cleanups to hybrid_rule.py * minor cleanups to pyomo_storage_rule_min_operating_cost * extra small cleanups to generic_converter_opt * added storage capacities as inputs to optimized controller * updated use of n_control_window and n_horizon_window

jaredthomas68

I think this is an excellent piece of work, well done. Thank you for the effort to make it relatively clean and straight forward. My thoughts are:

structurally I think it is very good. I guess we will find ways to improve as we move forward, but I like where it is at generally.
I am concerned with the number of getter and setter methods, are they really necessary?
more tests are needed for added functionality
lots of comments and print statements need to be removed, but that is expected in a draft
more comments would be helpful as there are some methods with little to no comments

jaredthomas68 · 2026-01-09T19:20:07Z

h2integrate/control/control_rules/converters/generic_converter_opt.py

+
+
+class PyomoDispatchGenericConverterMinOperatingCosts:
+    def __init__(


before going to production we will need some more comments and explanation here I think

jaredthomas68 · 2026-01-09T19:22:58Z

h2integrate/control/control_rules/converters/generic_converter_opt.py

+    def _create_parameters(self, pyomo_model: pyo.ConcreteModel):
+        """Create technology Pyomo parameters to add to the Pyomo model instance.
+
+        Method is currently passed but this can serve as a template to add parameters to the Pyomo


I'm not sure what you mean by "Method is currently passed"

This was a copy/past mistake. Fixed now!

jaredthomas68 · 2026-01-09T19:24:01Z

h2integrate/control/control_rules/converters/generic_converter_opt.py

+    def _create_constraints(self, pyomo_model: pyo.ConcreteModel):
+        """Create technology Pyomo parameters to add to the Pyomo model instance.
+
+        Method is currently passed but this can serve as a template to add constraints to the Pyomo


see above comment

jaredthomas68 · 2026-01-09T19:34:28Z

h2integrate/control/control_rules/storage/pyomo_storage_rule_min_operating_cost.py

+    #     initial_soc = self._check_initial_soc(initial_soc)
+    #     pyomo_model.initial_soc = round(initial_soc, self.round_digits)
+
+    @property


I wish we could avoid having so many getter and setter methods, but I don't have any good ideas for that at the moment (non-blocking).

jaredthomas68 · 2026-01-09T19:45:22Z

h2integrate/control/control_strategies/controller_opt_problem_state.py

+        solver_problem_dict = {
+            k.lower().replace(" ", "_"): v.value for k, v in solver_results.problem._list[0].items()
+        }
+        prob_to_attr_map = {


some unclear names in the solver, but this is a fairly nice solution for dealing with it

jaredthomas68 · 2026-01-09T19:46:41Z

h2integrate/control/control_strategies/controller_opt_problem_state.py

+        upper_bound = solver_problem_dict["upper_bound"]
+        lower_bound = solver_problem_dict["lower_bound"]
+        if upper_bound != 0.0:
+            gap = abs(upper_bound - lower_bound) / abs(upper_bound)


some comments here would be good. I think I get what you are doing, but it took me a minute

jaredthomas68 · 2026-01-09T19:48:19Z

h2integrate/control/control_strategies/pyomo_controllers.py

                            but has not been implemented yet."
                        )
                    )
+                    # TODO: implement optimized solutions; this is where pyomo_model would be used


remove comment

jaredthomas68 · 2026-01-09T19:54:18Z

h2integrate/control/control_strategies/pyomo_controllers.py

+        return dispatch_inputs
+
+
+class OptimizedDispatchController(SimpleBatteryControllerHeuristic):


This inheritance strikes me as odd since the parent and child are technically at the same level in their usage. If there are common elements they both need I think we should make a base class for them both to inherit from.

This is a good point. I've fixed this in the most recent update. Now it inherits from PyomoControllerBaseClass

jaredthomas68 · 2026-01-09T20:03:38Z

examples/25_pyomo_optimized_dispatch/tech_config.yaml

+      wind_speed: 9.
+    model_inputs:
+      performance_parameters:
+        num_turbines: 100


The wind farm rating is really high in comparison with the battery. I think the plots in the example would be more meaningful if you reduced the size of the wind farm

jaredthomas68 and others added 15 commits October 2, 2025 09:16

include storage rule file

df63126

Merge remote-tracking branch 'origin/develop' into pyomo_opt

73f87d7

Merge branch 'pyomo_opt' into feature/pyomo_opt

80782e1

Merging in current pyomo opt branch

Halfway there for pyomo opt

6971220

Add first objective function

5a2ce87

Updated dispatch optimization framework - add hybrid dispatch rule

c7923c4

Merge remote-tracking branch 'origin/develop' into feature/pyomo_opt

38c929d

Adding hybrid linking constraints and connecting variables in pyomo m…

03d7c1d

…in operating costs framework

Merge branch 'feature/pyomo_opt' of https://github.com/genevievestark…

9509748

…e/H2Integrate into feature/pyomo_opt

Merge remote-tracking branch 'origin/develop' into feature/pyomo_opt

5fa7165

Merge remote-tracking branch 'origin/develop' into feature/pyomo_opt

2194701

Final structural changes

c2f1bbb

Fix import statement

4d676fb

Fix imports and setter method

0c642d0

johnjasa added the in progress label Dec 18, 2025

genevievestarke added 2 commits December 23, 2025 16:02

First draft of running code

22e411f

Update example

efc2069

genevievestarke added the ready for review This PR is ready for input from folks label Dec 31, 2025

kbrunik and others added 6 commits January 2, 2026 11:13

Merge branch 'develop' into feature/pyomo_opt

8650683

test

e947332

fix precommits

581e101

Merge branch 'develop' into feature/pyomo_opt

1dbb52b

Fixing merge errors

4f2faea

Minor spelling changes

39ad186

jaredthomas68 self-requested a review January 6, 2026 22:38

elenya-grant self-requested a review January 6, 2026 22:55

genevievestarke added 2 commits January 7, 2026 12:46

Update example

ec3ad18

Update controller problem state method from Elenya

b1cc99b

genevievestarke and others added 3 commits January 7, 2026 12:59

Update example and changelog

24cc0b8

Clean up pyomo storage baseclass file

abf9d49

Merge branch 'develop' into feature/pyomo_opt

a2da8b9

elenya-grant reviewed Jan 8, 2026

View reviewed changes

jaredthomas68 reviewed Jan 9, 2026

View reviewed changes

johnjasa mentioned this pull request Jan 9, 2026

Add csv post process for time series variables #440

Merged

19 tasks

Enable heuristic dispatch to run with new pyomo changes

72205b2

johnjasa added needs modifications This PR has been reviewed, at least partially, and is ready for PR author response and removed ready for review This PR is ready for input from folks labels Jan 13, 2026

Clean up added files and example

5c16393

johnjasa requested review from elenya-grant and jaredthomas68 January 20, 2026 20:42

genevievestarke and others added 11 commits January 21, 2026 14:51

Adding first tests - do not pass yet

6de9803

Merge branch 'develop' into feature/pyomo_opt

dc059b9

Update docs and rename example

5d36008

Align naming with develop branch

ba6d65d

Update Ex 02 and update pyomo_controllers with naming in develop

bb8e7d8

updated other example tech configs

6a1d050

ran precommit on some files

57bf534

precommit on pyomo_controllers.py

0acaa30

Update test formatting

e3d0315

Update pyomo storage rule for test

a509354

Fix SOC linking bug

2342730



		class PyomoDispatchGenericConverterMinOperatingCosts:
		def __init__(

		return dispatch_inputs


		class OptimizedDispatchController(SimpleBatteryControllerHeuristic):

Enable load following optimization dispatch with Pyomo #407

Are you sure you want to change the base?

Enable load following optimization dispatch with Pyomo #407

Uh oh!

Conversation

genevievestarke commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bring Pyomo load following dispatch capabilities into H2I

Section 1: Type of Contribution

Section 2: Draft PR Checklist

TODO:

Type of Reviewer Feedback Requested (on Draft PR)

Section 3: General PR Checklist

Section 3: Related Issues

Section 4: Impacted Areas of the Software

Section 4.1: New Files

Section 4.2: Modified Files

Section 5: Additional Supporting Information

Section 6: Test Results, if applicable

Section 7 (Optional): New Model Checklist

Uh oh!

genevievestarke commented Dec 31, 2025

Uh oh!

elenya-grant left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaredthomas68 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

genevievestarke commented Dec 9, 2025 •

edited

Loading