-
Notifications
You must be signed in to change notification settings - Fork 27
Docs: Convert notebooks to scripts and executable markdown #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RHammond2
wants to merge
22
commits into
NatLabRockies:develop
Choose a base branch
from
RHammond2:docs/convert-notebooks
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Docs: Convert notebooks to scripts and executable markdown #464
RHammond2
wants to merge
22
commits into
NatLabRockies:develop
from
RHammond2:docs/convert-notebooks
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
code cleanup
documentation
Improvements or additions to documentation
ready for review
This PR is ready for input from folks
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the Jupyter Notebooks to Documentation Examples and Python Scripts for Better Docs and Diffs
This PR focuses on replacing all Jupyter notebooks in the
examples/anddocs/directories with simplified Python scripts and executable notebooks providing in depth demonstrations, respectively.Section 1: Type of Contribution
Section 2: Draft PR Checklist
TODO:
Type of Reviewer Feedback Requested (on Draft PR)
Structural feedback:
Implementation feedback:
Other feedback:
Section 3: General PR Checklist
docs/files are up-to-date, or added when necessaryCHANGELOG.mdhas been updated to describe the changes made in this PRSection 3: Related Issues
This will resolve #75
Section 4: Impacted Areas of the Software
Section 4.1: New Files
docs/control/controller_demonstrations.md: replaces the oldexamples/14_wind_hydrogen_dispatch/hydrogren_dispatch.ipynbexamples/14_wind_hydrogen_dispatch/hydrogren_dispatch.py: simplified version ofexamples/14_wind_hydrogen_dispatch/hydrogren_dispatch.ipynbdocs/user_guide/design_of_experiments_in_h2i.mdnow includes the detailed demonstration fromexamples/20_solar_electrolyzer_doe/run_csv_doe.ipynbexamples/20_solar_electrolyzer_doe/run_csv_doe.pyis a pared down version ofexamples/20_solar_electrolyzer_doe/run_csv_doe.ipynbdocs/user_guide/run_size_modes.md: replacesexamples/25_sizing_modes/run_size_modes.ipynband fixes bugsexamples/25_sizing_modes/run_size_modes.py: simplified form ofexamples/25_sizing_modes/run_size_modes.ipynbdocs/misc_resources/turbine_models_library_preprocessing.md: replacesdocs/user_guide/how_to_set_up_an_analysis.ipynb, and fixes broken functionality with minor formatting cleanup.docs/user_guide/how_to_set_up_an_analysis.md: replacesdocs/user_guide/how_to_set_up_an_analysis.ipynbSection 4.2: Modified Files
.gitignore: Includes more example output data files and folders.docs/_config.yml: ensures executable content doesn't get wrapped up in the many autosummary warnings, and raises a build errordocs/_toc.yml: updated to reflect the new or modified file references.Section 5: Additional Supporting Information
See the discussion in #75 for further details.
Section 6: Test Results, if applicable
N/A
Section 7 (Optional): New Model Checklist
docs/developer_guide/coding_guidelines.mdattrsclass to define theConfigto load in attributes for the modelBaseConfigorCostModelBaseConfiginitialize()method,setup()method,compute()methodCostModelBaseClasssupported_models.pycreate_financial_modelinh2integrate_model.pytest_all_examples.pydocs/user_guide/model_overview.mddocs/section<model_name>.mdis added to the_toc.yml