[Draft] Refactor input and output of wrapper #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The input configuration of the UIPS wrapper depended on reading text-input files. This has now been changed to use a new class UIPSOptions that encapsulates all these parameters. Additionally, instead of writing the results of the downsampling to file, these are now returned as part of the function. To demonstrate the behavior of this new interface a jupyter notebook based on the 2D Gaussian example was added to the tutorials repo. Additional work remains to support the previous interfaces as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input configuration of the UIPS wrapper depended on reading text-input files. This has now been changed to use a new class UIPSOptions that encapsulates all these parameters. Additionally, instead of writing the results of the downsampling to file, these are now returned as part of the function.
To demonstrate the behavior of this new interface a jupyter notebook based on the 2D Gaussian example was added to the tutorials repo.
Additional work remains to support the previous interface based on PrettyPrintParser.
This PR is intended to be a point of discussion to refactoring the UIPS package so that in can be used without relying in input/output files