Reorganize repository. Add rudimentary build system. Support Firefox Nightly#13
Reorganize repository. Add rudimentary build system. Support Firefox Nightly#13JoshTheDerf wants to merge 1 commit intoNateowami:masterfrom
Conversation
|
Wow, this is great, thanks! Seems there's a lot of code in This looks pretty good (still have to try it out). Perhaps we should make functions function get(key, fn) {
if(chrome) {
chrome.storage.local.get(key, fn);
}
else {
browser.storage.local.get(null, fn);
}
}This would shorten code a little, and remove the possible performance issue except from Firefox. It would also allow us to change things more easily when Firefox fixes the bug that requires us to use On the subject of code cleanup, would could probably cut the size of the code by a lot if we used Ractive and Foundation... just a thought. I'll try to get back to this again a little later. |
|
Yes, using a global get/set function would probably be useful, at least in the main file, though it would have to be implemented differently. And yeah, using Ractive/Foundation or Bootstrap would probably not be a bad idea, but I'm too lazy to do so at the moment. (Actually don't need Backloader at the moment here in the U.S.) |
Should've used multiple commits, my bad.
Everything appears to be working on all browsers listed, but there's likely a performance hit due to Firefox still having trouble with specified arguments to
browser.storage.local.getand therefore having to usenullto fetch everything.The build script is not bulletproof in any way, shape, or form.
Discussion pull request, not for direct merging without changes.