Remove publisherName from azureSignOptions (TrustedSigning v0.4.1 compat)#84
Merged
gwleuverink merged 1 commit intoNativePHP:mainfrom Feb 27, 2026
Merged
Conversation
…dSigning v0.4.1 The TrustedSigning PowerShell module v0.4.1 (installed by electron-builder) removed the -publisherName parameter from Invoke-TrustedSigning. Passing it now causes signing to fail with: "A parameter cannot be found that matches parameter name 'publisherName'". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gwleuverink
approved these changes
Feb 26, 2026
Collaborator
|
Good catch! Thanks 🙏 |
PeteBishwhip
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publisherNamefromazureSignOptionsinelectron-builder.mjsto fix Windows code signing failures withTrustedSigningPowerShell module v0.4.1+.azurePublisherNamevariable and simplifies the guard condition accordingly.Problem
electron-builder delegates Windows Azure Trusted Signing to the
Invoke-TrustedSigningPowerShell cmdlet (from theTrustedSigningmodule). In version 0.4.1 of that module, the-publisherNameparameter was removed. Because NativePHP's config still passespublisherNameinazureSignOptions, electron-builder forwards it as-publisherNameto the cmdlet, which then fails with:You can verify the parameter was removed by comparing the TrustedSigning module v0.4.0 and v0.4.1 releases, or by inspecting electron-builder's
windowsSignAzureManager.jswhich pins the install toTrustedSigning@0.4.1.Fix
Remove the
publisherNameproperty from theazureSignOptionsobject, theazurePublisherNamevariable that fed it, and theazurePublisherName &&check from the guard condition (since we no longer need that env var to be set).🤖 Generated with Claude Code