Skip to content

Remove publisherName from azureSignOptions (TrustedSigning v0.4.1 compat)#84

Merged
gwleuverink merged 1 commit intoNativePHP:mainfrom
igorgudelj:fix/remove-azure-publisher-name
Feb 27, 2026
Merged

Remove publisherName from azureSignOptions (TrustedSigning v0.4.1 compat)#84
gwleuverink merged 1 commit intoNativePHP:mainfrom
igorgudelj:fix/remove-azure-publisher-name

Conversation

@igorgudelj
Copy link
Contributor

Summary

  • Removes publisherName from azureSignOptions in electron-builder.mjs to fix Windows code signing failures with TrustedSigning PowerShell module v0.4.1+.
  • Removes the now-unused azurePublisherName variable and simplifies the guard condition accordingly.

Problem

electron-builder delegates Windows Azure Trusted Signing to the Invoke-TrustedSigning PowerShell cmdlet (from the TrustedSigning module). In version 0.4.1 of that module, the -publisherName parameter was removed. Because NativePHP's config still passes publisherName in azureSignOptions, electron-builder forwards it as -publisherName to the cmdlet, which then fails with:

A parameter cannot be found that matches parameter name 'publisherName'.

You can verify the parameter was removed by comparing the TrustedSigning module v0.4.0 and v0.4.1 releases, or by inspecting electron-builder's windowsSignAzureManager.js which pins the install to TrustedSigning@0.4.1.

Fix

Remove the publisherName property from the azureSignOptions object, the azurePublisherName variable that fed it, and the azurePublisherName && check from the guard condition (since we no longer need that env var to be set).

🤖 Generated with Claude Code

…dSigning v0.4.1

The TrustedSigning PowerShell module v0.4.1 (installed by electron-builder)
removed the -publisherName parameter from Invoke-TrustedSigning. Passing it
now causes signing to fail with: "A parameter cannot be found that matches
parameter name 'publisherName'".

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@gwleuverink
Copy link
Collaborator

Good catch! Thanks 🙏

Copy link
Member

@simonhamp simonhamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@gwleuverink gwleuverink merged commit 20ddf72 into NativePHP:main Feb 27, 2026
28 checks passed
@igorgudelj igorgudelj deleted the fix/remove-azure-publisher-name branch February 28, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants