Bump electron-builder to ^26.0.0 to fix Azure signing with spaces in path#86
Merged
simonhamp merged 1 commit intoNativePHP:mainfrom Mar 4, 2026
Merged
Conversation
…path Azure Trusted Signing fails when the project path contains spaces (e.g. C:\Users\John Doe\project). The -Files parameter passed to Invoke-TrustedSigning was not quoted, causing PowerShell to split the path at the space. This was fixed upstream in electron-builder#8606 (commit a0e635c), released in app-builder-lib v26.0.0. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gwleuverink
approved these changes
Feb 28, 2026
Collaborator
|
Great! We were just discussing this yesterday. Thank you 🙏 |
simonhamp
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
C:\Users\John Doe\project). The-Filesparameter passed toInvoke-TrustedSigningis not quoted, so PowerShell splits the path at the space.a0e635c), released inapp-builder-libv26.0.0.electron-builderfrom^25.1.8to^26.0.0to pick up the fix.Reproduction
C:\Users\John Doe\Herd\myapp)php artisan native:publish winSignTool Error: File not found: C:\Users\JohnTest plan