Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions config/nativephp.php
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,15 @@
// 'rm -rf public/build',
],

/**
* The NSIS installer configuration for Windows builds.
*
* @see https://www.electron.build/generated/nsisoptions
*/
'nsis' => [
'delete_app_data_on_uninstall' => env('NATIVEPHP_NSIS_DELETE_APP_DATA', false),
],

/**
* Custom PHP binary path.
*/
Expand Down
2 changes: 2 additions & 0 deletions resources/electron/electron-builder.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const appVersion = process.env.NATIVEPHP_APP_VERSION;
const appCopyright = process.env.NATIVEPHP_APP_COPYRIGHT;
const deepLinkProtocol = process.env.NATIVEPHP_DEEPLINK_SCHEME;
const updaterEnabled = process.env.NATIVEPHP_UPDATER_ENABLED === 'true';
const deleteAppDataOnUninstall = process.env.NATIVEPHP_NSIS_DELETE_APP_DATA === 'true';

// Azure signing configuration
const azureEndpoint = process.env.NATIVEPHP_AZURE_ENDPOINT;
Expand Down Expand Up @@ -95,6 +96,7 @@ export default {
shortcutName: '${productName}',
uninstallDisplayName: '${productName}',
createDesktopShortcut: 'always',
deleteAppDataOnUninstall: deleteAppDataOnUninstall,
},
protocols: {
name: deepLinkProtocol,
Expand Down
1 change: 1 addition & 0 deletions src/Drivers/Electron/Commands/BuildCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ protected function getEnvironmentVariables(): array
'NATIVEPHP_APP_FILENAME' => Str::slug(config('app.name')),
'NATIVEPHP_APP_AUTHOR' => config('nativephp.author'),
'NATIVEPHP_UPDATER_CONFIG' => json_encode(Updater::builderOptions()),
'NATIVEPHP_NSIS_DELETE_APP_DATA' => config('nativephp.nsis.delete_app_data_on_uninstall') ? 'true' : 'false',
'NATIVEPHP_DEEPLINK_SCHEME' => config('nativephp.deeplink_scheme'),
// Notarization
'NATIVEPHP_APPLE_ID' => config('nativephp-internal.notarization.apple_id'),
Expand Down
31 changes: 31 additions & 0 deletions tests/Build/BuildCommandEnvironmentVariablesTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<?php

use Illuminate\Support\Facades\Config;
use Native\Desktop\Drivers\Electron\Commands\BuildCommand;

it('passes NSIS delete app data flag as true when config is enabled', function () {
Config::set('nativephp.nsis.delete_app_data_on_uninstall', true);

$command = app(BuildCommand::class);
$envVars = (new ReflectionMethod($command, 'getEnvironmentVariables'))->invoke($command);

expect($envVars['NATIVEPHP_NSIS_DELETE_APP_DATA'])->toBe('true');
});

it('passes NSIS delete app data flag as false when config is disabled', function () {
Config::set('nativephp.nsis.delete_app_data_on_uninstall', false);

$command = app(BuildCommand::class);
$envVars = (new ReflectionMethod($command, 'getEnvironmentVariables'))->invoke($command);

expect($envVars['NATIVEPHP_NSIS_DELETE_APP_DATA'])->toBe('false');
});

it('defaults NSIS delete app data flag to false when config is not set', function () {
Config::set('nativephp.nsis.delete_app_data_on_uninstall', null);

$command = app(BuildCommand::class);
$envVars = (new ReflectionMethod($command, 'getEnvironmentVariables'))->invoke($command);

expect($envVars['NATIVEPHP_NSIS_DELETE_APP_DATA'])->toBe('false');
});
Loading