Skip to content

Fix uncaught exception in stopProcess when process already exited #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
igorgudelj wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix uncaught exception in stopProcess when process already exited #91

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4d7790
Fix uncaught exception in stopProcess when process already exited
igorgudelj Mar 2, 2026
1312b7b
Add console.log in catch block when process already exited
igorgudelj Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions resources/electron/electron-plugin/src/server/api/childProcess.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,13 @@ function stopProcess(alias) {

console.log('Process [' + alias + '] stopping with PID [' + proc.pid + '].');

// @ts-ignore
killSync(proc.pid, 'SIGTERM', true); // Kill tree
proc.kill(); // Does not work but just in case. (do not put before killSync)
try {
// @ts-ignore
killSync(proc.pid, 'SIGTERM', true); // Kill tree
proc.kill(); // Does not work but just in case. (do not put before killSync)
} catch (e) {
console.log('Process [' + alias + '] already exited — nothing to kill.');
}
}

export function stopAllProcesses() {
Expand Down
Loading